Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bazel] Enable --incompatible_disallow_empty_glob #2642

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

keith
Copy link
Contributor

@keith keith commented Apr 19, 2024

This way downstream consumers can enable this flag as well

This way downstream consumers can enable this flag as well
@keith keith requested a review from a team as a code owner April 19, 2024 20:16
@malkia
Copy link

malkia commented Apr 20, 2024

I have a list in my soft fork, with few more incompatbiles that were enabled (whatever I can) - https://github.com/malkia/opentelemetry-cpp/blob/main/.bazelrc#L92 - although that specifically did not work - I think it was for the prometheus-cpp module?

@keith keith marked this pull request as draft May 23, 2024 23:09
@keith
Copy link
Contributor Author

keith commented May 23, 2024

depends on jupp0r/prometheus-cpp#715 and probably some other stuff

Copy link

codecov bot commented Jun 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.68%. Comparing base (497eaf4) to head (46f37c7).
Report is 79 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2642      +/-   ##
==========================================
+ Coverage   87.12%   87.68%   +0.56%     
==========================================
  Files         200      190      -10     
  Lines        6109     5851     -258     
==========================================
- Hits         5322     5130     -192     
+ Misses        787      721      -66     

see 78 files with indirect coverage changes

@marcalff
Copy link
Member

marcalff commented Jun 12, 2024

depends on jupp0r/prometheus-cpp#715 and probably some other stuff

This PR in prometheus-cpp:

is merged, but there is no release yet that includes it.

Opentelemetry-cpp is using the prometheus-cpp 1.2.4 tag.

Waiting on release 1.2.5 from prometheus (adding blocked tag)

@marcalff marcalff added the issue:blocked Fix blocked, waiting for other fixes as prerequisites label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
issue:blocked Fix blocked, waiting for other fixes as prerequisites
3 participants