-
Notifications
You must be signed in to change notification settings - Fork 395
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bazel] Enable --incompatible_disallow_empty_glob #2642
base: main
Are you sure you want to change the base?
[bazel] Enable --incompatible_disallow_empty_glob #2642
Conversation
This way downstream consumers can enable this flag as well
I have a list in my soft fork, with few more incompatbiles that were enabled (whatever I can) - https://github.com/malkia/opentelemetry-cpp/blob/main/.bazelrc#L92 - although that specifically did not work - I think it was for the prometheus-cpp module? |
depends on jupp0r/prometheus-cpp#715 and probably some other stuff |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2642 +/- ##
==========================================
+ Coverage 87.12% 87.68% +0.56%
==========================================
Files 200 190 -10
Lines 6109 5851 -258
==========================================
- Hits 5322 5130 -192
+ Misses 787 721 -66 |
This PR in prometheus-cpp: is merged, but there is no release yet that includes it. Opentelemetry-cpp is using the prometheus-cpp 1.2.4 tag. Waiting on release 1.2.5 from prometheus (adding blocked tag) |
This way downstream consumers can enable this flag as well