Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SSL Version policies] Update description, docs and add default values #1046

Merged
merged 3 commits into from
Aug 29, 2023

Conversation

htcfreek
Copy link
Contributor

@htcfreek htcfreek commented Aug 4, 2023

Fixes #1039.

This PR does the following:

  • It updates the documentation and adds the default value for both policies to it.
  • It fixes the explanation of SSLVersionMin policy by changing the default value to TLS1.2 in the ADMX templates for Windows.
  • It adds defaultValue property to the presentation definition in the ADMX templates for Windows. (Now when the policy is set to enabled the default value of FF is selected automatically.)
@mkaply
Copy link
Collaborator

mkaply commented Aug 14, 2023

Sorry I haven't reviewed this yet. I'll get to it this week.

My biggest question is don't we need to keep the old policy around so that people can unset it to use the new policy? Usually I deprecate something because otherwise someone can't ever change the old values once we remove them.

@htcfreek
Copy link
Contributor Author

These are only visual changes. It only updates the description text and the preselected value.

There are no changes on the registry part. And I didn't remove any of the available SSL versions.

@mkaply mkaply merged commit b41d108 into mozilla:master Aug 29, 2023
@mkaply
Copy link
Collaborator

mkaply commented Aug 29, 2023

Thank you for this!

@htcfreek htcfreek deleted the FfPolSSL branch August 29, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants