Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: Enable setting the replica number and resource group during collection creation (#34403) #34561

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from
Open

enhance: Enable setting the replica number and resource group during collection creation (#34403) #34561

wants to merge 1 commit into from

Conversation

weiliu1031
Copy link
Contributor

issue: #30040
pr: #34403
@weiliu1031
enhance: Enable setting the replica number and resource group during …
ef2fe42 
…collection creation (milvus-io#34403)

issue: milvus-io#30040

---------

Signed-off-by: Wei Liu <wei.liu@zilliz.com>
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weiliu1031
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 10, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 10, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 86.44068% with 8 lines in your changes missing coverage. Please review.

Project coverage is 84.41%. Comparing base (60aab15) to head (ef2fe42).
Report is 3 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34561      +/-   ##
==========================================
- Coverage   84.41%   84.41%   -0.01%     
==========================================
  Files         786      786              
  Lines      112475   112519      +44     
==========================================
+ Hits        94951    94982      +31     
- Misses      13305    13323      +18     
+ Partials     4219     4214       -5
Files Coverage Δ
tests/integration/util_collection.go 100.00% <100.00%> (ø)
internal/querycoordv2/meta/coordinator_broker.go 91.28% <91.66%> (+1.73%) ⬆️
internal/querycoordv2/services.go 86.23% <66.66%> (-0.70%) ⬇️
pkg/common/common.go 79.41% <78.94%> (-0.19%) ⬇️

... and 34 files with indirect coverage changes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement sig/testing size/L Denotes a PR that changes 100-499 lines. test/integration integration test
2 participants
@weiliu1031 @sre-ci-robot