Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Support set clustering compaction's weight in datanode tasks scheduling #34543

Closed
wants to merge 1 commit into from

Conversation

wayblink
Copy link
Collaborator

@wayblink wayblink commented Jul 9, 2024

@sre-ci-robot sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 9, 2024
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wayblink
To complete the pull request process, please assign wxyucs after the PR has been reviewed.
You can assign the PR to them by writing /assign @wxyucs in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement do-not-merge/missing-related-issue labels Jul 9, 2024
Copy link
Contributor

mergify bot commented Jul 9, 2024

@wayblink Please associate the related issue to the body of your Pull Request. (eg. “issue: #”)

Signed-off-by: wayblink <anyang.wang@zilliz.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

Attention: Patch coverage is 47.82609% with 12 lines in your changes missing coverage. Please review.

Project coverage is 69.72%. Comparing base (eae4dfc) to head (cdf2dd0).
Report is 11 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##           master   #34543       +/-   ##
===========================================
- Coverage   84.35%   69.72%   -14.63%     
===========================================
  Files         858     1127      +269     
  Lines      115248   139344    +24096     
===========================================
- Hits        97212    97156       -56     
- Misses      13734    37897    +24163     
+ Partials     4302     4291       -11     
Files Coverage Δ
pkg/util/paramtable/component_param.go 98.49% <100.00%> (+<0.01%) ⬆️
...ternal/datanode/compaction/clustering_compactor.go 61.69% <0.00%> (-0.18%) ⬇️
internal/datanode/compaction/l0_compactor.go 90.83% <0.00%> (-0.73%) ⬇️
internal/datanode/compaction/mix_compactor.go 70.64% <0.00%> (-0.25%) ⬇️
internal/datanode/compaction/executor.go 86.52% <14.28%> (-3.78%) ⬇️

... and 306 files with indirect coverage changes

@wayblink wayblink closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/L Denotes a PR that changes 100-499 lines.
2 participants