Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: [cherry-pick] Refine clustering compaction latency metrics #34539

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

wayblink
Copy link
Collaborator

@wayblink wayblink commented Jul 9, 2024

issue: #34527
pr: #34528

@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 9, 2024
Signed-off-by: wayblink <anyang.wang@zilliz.com>
Copy link

codecov bot commented Jul 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.74%. Comparing base (15adb2f) to head (403ed41).
Report is 7 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34539      +/-   ##
==========================================
- Coverage   80.74%   80.74%   -0.01%     
==========================================
  Files        1051     1051              
  Lines      135835   135835              
==========================================
- Hits       109678   109677       -1     
  Misses      21945    21945              
- Partials     4212     4213       +1     
Files Coverage Δ
internal/datacoord/compaction_task_clustering.go 47.33% <100.00%> (ø)
pkg/metrics/datacoord_metrics.go 65.07% <ø> (ø)

... and 24 files with indirect coverage changes

@czs007 czs007 added this to the 2.4.6 milestone Jul 11, 2024
@czs007
Copy link
Contributor

czs007 commented Jul 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit 9dc98ac into milvus-io:2.4 Jul 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm size/XS Denotes a PR that changes 0-9 lines.
3 participants