Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Fix no L0 compaction tasks are executed #34537

Merged
merged 2 commits into from
Jul 15, 2024
Merged

fix: Fix no L0 compaction tasks are executed #34537

merged 2 commits into from
Jul 15, 2024

Conversation

bigsheeper
Copy link
Contributor

The nodeID for compaction task initialization is 0. This PR adjusts the task reassignment conditions to allow new compaction tasks to be reassigned and executed.

issue: #34460
@bigsheeper
fix: Fix no L0 compaction tasks are executed
35d0446 
Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug labels Jul 9, 2024
@bigsheeper bigsheeper mentioned this pull request Jul 9, 2024
Merged
@bigsheeper
Copy link
Contributor Author

rerun ut
sre-ci-robot pushed a commit that referenced this pull request Jul 10, 2024
@bigsheeper
fix: Fix no L0 compaction tasks are executed (#34537) (#34538)
1589d68 
The nodeID for compaction task initialization is 0. This PR adjusts the
task reassignment conditions to allow new compaction tasks to be
reassigned and executed.

issue: #34460

pr: #34537

Signed-off-by: bigsheeper <yihao.dai@zilliz.com>
@bigsheeper
Copy link
Contributor Author

rerun ut
@wayblink
Copy link
Collaborator

/lgtm
@sre-ci-robot sre-ci-robot removed the lgtm label Jul 11, 2024
@mergify mergify bot added the ci-passed label Jul 11, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 11, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.39%. Comparing base (c332f69) to head (d24a5bd).
Report is 10 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34537      +/-   ##
==========================================
+ Coverage   80.69%   84.39%   +3.69%     
==========================================
  Files        1127      876     -251     
  Lines      139341   115798   -23543     
==========================================
- Hits       112443    97728   -14715     
+ Misses      22613    13750    -8863     
- Partials     4285     4320      +35
Files Coverage Δ
internal/datacoord/compaction_task_clustering.go 47.33% <100.00%> (ø)
internal/datacoord/compaction_task_l0.go 63.07% <100.00%> (-1.66%) ⬇️
internal/datacoord/compaction_task_mix.go 66.82% <100.00%> (-2.77%) ⬇️

... and 298 files with indirect coverage changes
@xiaofan-luan
Copy link
Contributor

/approve
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bigsheeper, xiaofan-luan

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@bigsheeper bigsheeper mentioned this pull request Jul 15, 2024
Merged
@wayblink
Copy link
Collaborator

/lgtm
@sre-ci-robot sre-ci-robot merged commit 1495b7a into milvus-io:master Jul 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
4 participants
@bigsheeper @wayblink @xiaofan-luan @sre-ci-robot