Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhance: Add back compactionTaskNum metrics #34534

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

XuanYang-cn
Copy link
Contributor

@XuanYang-cn XuanYang-cn commented Jul 9, 2024

Fix L0 compaction task recover unable to set segment
not isCompacting

See also: #34460
pr: #34583

Signed-off-by: yangxuan xuan.yang@zilliz.com

@sre-ci-robot sre-ci-robot added the size/M Denotes a PR that changes 30-99 lines. label Jul 9, 2024
Copy link
Contributor

mergify bot commented Jul 9, 2024

@XuanYang-cn Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)

@mergify mergify bot added kind/enhancement Issues or changes related to enhancement ci-passed labels Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

Attention: Patch coverage is 73.78641% with 27 lines in your changes missing coverage. Please review.

Project coverage is 80.73%. Comparing base (a7190b0) to head (3f69b26).
Report is 2 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34534      +/-   ##
==========================================
- Coverage   84.42%   80.73%   -3.69%     
==========================================
  Files         786     1051     +265     
  Lines      112477   135845   +23368     
==========================================
+ Hits        94958   109679   +14721     
- Misses      13310    21947    +8637     
- Partials     4209     4219      +10     
Files Coverage Δ
internal/datacoord/compaction_policy_l0.go 97.80% <100.00%> (-0.05%) ⬇️
internal/datacoord/meta.go 86.14% <100.00%> (+0.17%) ⬆️
internal/metastore/kv/datacoord/kv_catalog.go 75.85% <100.00%> (ø)
internal/datacoord/compaction_task_clustering.go 47.74% <0.00%> (+0.40%) ⬆️
internal/datacoord/compaction.go 77.22% <91.52%> (+1.94%) ⬆️
internal/datacoord/compaction_task_l0.go 61.66% <33.33%> (-1.41%) ⬇️
internal/datacoord/compaction_trigger_v2.go 72.57% <36.36%> (+0.31%) ⬆️
internal/datacoord/compaction_task_mix.go 67.90% <42.85%> (-1.68%) ⬇️

... and 298 files with indirect coverage changes

@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. and removed size/M Denotes a PR that changes 30-99 lines. labels Jul 10, 2024
@mergify mergify bot removed the ci-passed label Jul 10, 2024
@yanliang567 yanliang567 added this to the 2.4.6 milestone Jul 10, 2024
Fix L0 compaction task recover unable to set segment
not isCompacting

See also: milvus-io#34460
pr: milvus-io#34583

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@czs007
Copy link
Contributor

czs007 commented Jul 10, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@czs007 czs007 added the manual-pass manually set pass before ci-passed labeled label Jul 10, 2024
@sre-ci-robot sre-ci-robot merged commit 2bef9c3 into milvus-io:2.4 Jul 10, 2024
11 of 12 checks passed
@XuanYang-cn XuanYang-cn deleted the add-back-compaction-num branch July 11, 2024 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. do-not-merge/missing-related-pr kind/enhancement Issues or changes related to enhancement lgtm manual-pass manually set pass before ci-passed labeled size/L Denotes a PR that changes 100-499 lines.
4 participants