Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: [skip e2e]Enable compaction it test #34526

Merged
merged 1 commit into from
Jul 15, 2024
Merged

enhance: [skip e2e]Enable compaction it test #34526

merged 1 commit into from
Jul 15, 2024

Conversation

XuanYang-cn
Copy link
Contributor

No description provided.

@XuanYang-cn
enhance: Enable compaction it test
6c29ad9 
Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 9, 2024
@XuanYang-cn
Copy link
Contributor Author

rerun ut
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.37%. Comparing base (eae4dfc) to head (6c29ad9).
Report is 39 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34526      +/-   ##
==========================================
+ Coverage   84.35%   84.37%   +0.02%     
==========================================
  Files         858      858              
  Lines      115248   115256       +8     
==========================================
+ Hits        97212    97244      +32     
+ Misses      13734    13721      -13     
+ Partials     4302     4291      -11

see 27 files with indirect coverage changes
@XuanYang-cn
Copy link
Contributor Author

rerun ut
@XuanYang-cn XuanYang-cn changed the title enhance: Enable compaction it test Jul 15, 2024
@XuanYang-cn XuanYang-cn changed the title enhance: [skip-e2e]Enable compaction it test Jul 15, 2024
@mergify mergify bot added the ci-passed label Jul 15, 2024
congqixia
congqixia approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@congqixia congqixia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: congqixia, XuanYang-cn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sre-ci-robot sre-ci-robot merged commit eb472b7 into milvus-io:master Jul 15, 2024
11 checks passed
@XuanYang-cn XuanYang-cn deleted the open-it-comp branch July 16, 2024 07:49
XuanYang-cn added a commit to XuanYang-cn/milvus that referenced this pull request Jul 16, 2024
@XuanYang-cn
enhance: [skip e2e]Enable compaction it test (milvus-io#34526)
aa2486e 
pr: milvus-io#34526

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
@XuanYang-cn XuanYang-cn mentioned this pull request Jul 16, 2024
Merged
sre-ci-robot pushed a commit that referenced this pull request Jul 16, 2024
@XuanYang-cn
enhance: [skip e2e]Enable compaction it test (#34526) (#34720)
edefc3c 
pr: #34526

Signed-off-by: yangxuan <xuan.yang@zilliz.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved area/test ci-passed dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement lgtm sig/testing size/XS Denotes a PR that changes 0-9 lines. test/integration integration test
3 participants
@XuanYang-cn @sre-ci-robot @congqixia