Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: unstable UT for level0 deletion #34525

Merged
merged 1 commit into from
Jul 11, 2024

Conversation

jaime0815
Copy link
Contributor

@jaime0815 jaime0815 commented Jul 9, 2024

issue: #34533
pr: #34524

Signed-off-by: jaime <yun.zhang@zilliz.com>
@sre-ci-robot sre-ci-robot added the size/XS Denotes a PR that changes 0-9 lines. label Jul 9, 2024
@mergify mergify bot added dco-passed DCO check passed. kind/bug Issues or changes related a bug ci-passed and removed ci-passed labels Jul 9, 2024
Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.78%. Comparing base (f6cd841) to head (02831d9).
Report is 14 commits behind head on 2.4.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##              2.4   #34525      +/-   ##
==========================================
+ Coverage   80.76%   80.78%   +0.01%     
==========================================
  Files        1051     1051              
  Lines      135826   135830       +4     
==========================================
+ Hits       109705   109725      +20     
+ Misses      21916    21908       -8     
+ Partials     4205     4197       -8     

see 27 files with indirect coverage changes

@czs007
Copy link
Contributor

czs007 commented Jul 11, 2024

/approve
/lgtm

@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, jaime0815

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@sre-ci-robot sre-ci-robot merged commit bfd386a into milvus-io:2.4 Jul 11, 2024
11 checks passed
@jaime0815 jaime0815 deleted the fix-unstable-ut-79-24 branch July 11, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved ci-passed dco-passed DCO check passed. kind/bug Issues or changes related a bug lgtm size/XS Denotes a PR that changes 0-9 lines.
3 participants