enhance: Alter compactTo segments before compactFrom to avoid data loss if crash #34513

wayblink · 2024-07-09T04:06:40Z

#34512

mergify · 2024-07-09T04:45:36Z

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink · 2024-07-09T06:14:26Z

/run-cpu-e2e

codecov · 2024-07-09T06:52:01Z

Codecov Report

Attention: Patch coverage is 82.60870% with 12 lines in your changes missing coverage. Please review.

Project coverage is 71.50%. Comparing base (07b94b4) to head (ef6510a).
Report is 6 commits behind head on master.

❗ Current head ef6510a differs from pull request most recent head 3569bc6

Please upload reports for the commit 3569bc6 to get more accurate results.

Additional details and impacted files

@@             Coverage Diff             @@
##           master   #34513       +/-   ##
===========================================
- Coverage   84.39%   71.50%   -12.89%     
===========================================
  Files         876     1127      +251     
  Lines      115815   139314    +23499     
===========================================
+ Hits        97740    99614     +1874     
- Misses      13757    35414    +21657     
+ Partials     4318     4286       -32

Files	Coverage Δ
internal/datacoord/compaction_trigger.go	`86.80% <75.00%> (+0.79%)`	⬆️
internal/datacoord/meta.go	`85.32% <83.07%> (-0.68%)`	⬇️

... and 331 files with indirect coverage changes

mergify · 2024-07-09T06:52:41Z

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink · 2024-07-09T07:15:30Z

/run-cpu-e2e

mergify · 2024-07-09T07:33:21Z

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink · 2024-07-09T08:02:48Z

/run-cpu-e2e

mergify · 2024-07-09T08:41:26Z

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

mergify · 2024-07-09T10:25:30Z

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink · 2024-07-09T11:03:40Z

/run-cpu-e2e

mergify · 2024-07-09T11:23:36Z

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink · 2024-07-09T11:53:54Z

/run-cpu-e2e

mergify · 2024-07-09T12:12:16Z

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink · 2024-07-09T12:48:43Z

rerun ut

mergify · 2024-07-10T11:19:06Z

@wayblink E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.

wayblink · 2024-07-10T11:39:38Z

/run-cpu-e2e

Signed-off-by: wayblink <anyang.wang@zilliz.com>

czs007 · 2024-07-11T13:01:43Z

/approve
/lgtm

sre-ci-robot · 2024-07-11T13:01:57Z

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: czs007, wayblink

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

~~internal/datacoord/OWNERS~~ [czs007]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

xiaofan-luan · 2024-07-11T13:57:17Z

internal/datacoord/meta.go

 		binlogs = append(binlogs, metastore.BinlogsIncrement{Segment: seg})
 	}
-	if err := m.catalog.AlterSegments(m.ctx, append(compactFromInfos, newSegmentInfos...), binlogs...); err != nil {
-		log.Warn("fail to alter segments and new segment", zap.Error(err))
+	// alter compactTo before compactFrom segments to avoid data lost if service crash during AlterSegments


should we do m.segments.SetSegment(compactToSegmentInfo.GetID(), compactToSegmentInfo)
after we store compactToInfos?

can not finish this call in one request seems to be dangerous.
can we only handle 100 segments max at a time?

… avoid data loss if crash (#34532) issue: #34512 pr: #34513 Signed-off-by: wayblink <anyang.wang@zilliz.com>

…ss if crash (milvus-io#34513) milvus-io#34512 Signed-off-by: wayblink <anyang.wang@zilliz.com>

sre-ci-robot requested review from cydrain and sunby July 9, 2024 04:06

sre-ci-robot added the size/L Denotes a PR that changes 100-499 lines. label Jul 9, 2024

mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 9, 2024

wayblink force-pushed the refine-meta branch from 5e5d79f to 312cef7 Compare July 9, 2024 10:05

wayblink mentioned this pull request Jul 9, 2024

enhance: [cherry-pick] Alter compactTo segments before compactFrom to avoid data loss if crash #34532

Merged

wayblink force-pushed the refine-meta branch from 312cef7 to 1d2e9a8 Compare July 10, 2024 10:36

wayblink force-pushed the refine-meta branch from 1d2e9a8 to ef6510a Compare July 10, 2024 12:30

mergify bot added the ci-passed label Jul 10, 2024

Alter compactTo segments before compactFrom to avoid data loss if crash

3569bc6

Signed-off-by: wayblink <anyang.wang@zilliz.com>

wayblink force-pushed the refine-meta branch from ef6510a to 3569bc6 Compare July 11, 2024 12:58

mergify bot removed the ci-passed label Jul 11, 2024

sre-ci-robot assigned czs007 Jul 11, 2024

sre-ci-robot added the lgtm label Jul 11, 2024

sre-ci-robot added the approved label Jul 11, 2024

xiaofan-luan reviewed Jul 11, 2024

View reviewed changes

sre-ci-robot pushed a commit that referenced this pull request Jul 11, 2024

enhance: [cherry-pick] Alter compactTo segments before compactFrom to…

86b57b7

… avoid data loss if crash (#34532) issue: #34512 pr: #34513 Signed-off-by: wayblink <anyang.wang@zilliz.com>

mergify bot added the ci-passed label Jul 11, 2024

sre-ci-robot merged commit 358e9a1 into milvus-io:master Jul 11, 2024
10 checks passed

chyezh pushed a commit to chyezh/milvus that referenced this pull request Jul 15, 2024

enhance: Alter compactTo segments before compactFrom to avoid data lo…

bb1c9de

…ss if crash (milvus-io#34513) milvus-io#34512 Signed-off-by: wayblink <anyang.wang@zilliz.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

enhance: Alter compactTo segments before compactFrom to avoid data loss if crash #34513

enhance: Alter compactTo segments before compactFrom to avoid data loss if crash #34513

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

codecov bot commented Jul 9, 2024 •

edited

Loading

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 10, 2024

wayblink commented Jul 10, 2024

czs007 commented Jul 11, 2024

sre-ci-robot commented Jul 11, 2024

xiaofan-luan Jul 11, 2024

xiaofan-luan Jul 11, 2024

enhance: Alter compactTo segments before compactFrom to avoid data loss if crash #34513

enhance: Alter compactTo segments before compactFrom to avoid data loss if crash #34513

Conversation

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

codecov bot commented Jul 9, 2024 • edited Loading

Codecov Report

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 9, 2024

wayblink commented Jul 9, 2024

mergify bot commented Jul 10, 2024

wayblink commented Jul 10, 2024

czs007 commented Jul 11, 2024

sre-ci-robot commented Jul 11, 2024

xiaofan-luan Jul 11, 2024

Choose a reason for hiding this comment

xiaofan-luan Jul 11, 2024

Choose a reason for hiding this comment

codecov bot commented Jul 9, 2024 •

edited

Loading