Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Upgraded Azidentity Package to v1.6.0 (#34464) #34487

Open
wants to merge 1 commit into
base: 2.4
Choose a base branch
from
Open

fix: Upgraded Azidentity Package to v1.6.0 (#34464) #34487

wants to merge 1 commit into from

Conversation

Ald392
Copy link
Contributor

@Ald392 Ald392 commented Jul 8, 2024 •
edited
Loading

issue : #34456
pr: #34464
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Ald392
To complete the pull request process, please assign congqixia after the PR has been reviewed.
You can assign the PR to them by writing /assign @congqixia in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@sre-ci-robot sre-ci-robot added size/L Denotes a PR that changes 100-499 lines. area/dependency Pull requests that update a dependency file labels Jul 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 8, 2024

@Ald392 Thanks for your contribution. Please submit with DCO, see the contributing guide https://github.com/milvus-io/milvus/blob/master/CONTRIBUTING.md#developer-certificate-of-origin-dco.
@mergify mergify bot added the needs-dco DCO is missing in this pull request. label Jul 8, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 8, 2024

@Ald392 Please associate the related pr of master to the body of your Pull Request. (eg. “pr: #”)
@mergify mergify bot added do-not-merge/missing-related-pr kind/bug Issues or changes related a bug labels Jul 8, 2024
@Ald392
fix: Upgraded Azidentity Package to v1.6.0 (milvus-io#34464)
96e6a42 
issue : milvus-io#34456

Signed-off-by: Aldrin <imagesai32@gmail.com>
@mergify mergify bot added dco-passed DCO check passed. and removed needs-dco DCO is missing in this pull request. do-not-merge/missing-related-pr labels Jul 8, 2024
@xiaofan-luan
Copy link
Contributor

@Ald392
could you rebase with lastest 2.4? seems that the ut has some issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/dependency Pull requests that update a dependency file dco-passed DCO check passed. kind/bug Issues or changes related a bug size/L Denotes a PR that changes 100-499 lines.
3 participants
@Ald392 @sre-ci-robot @xiaofan-luan