Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

enhance: streaming node client implementation #34467

Closed
wants to merge 2 commits into from
Closed

enhance: streaming node client implementation #34467

wants to merge 2 commits into from

Conversation

chyezh
Copy link
Contributor

@chyezh chyezh commented Jul 7, 2024

issue: #33285

  • add streaming node grpc client wrapper
  • add unittest for streaming node grpc client side
@sre-ci-robot sre-ci-robot added the size/XXL Denotes a PR that changes 1000+ lines. label Jul 7, 2024
@chyezh chyezh mentioned this pull request Jul 7, 2024
Open
43 tasks
@sre-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: chyezh
To complete the pull request process, please assign xiaofan-luan after the PR has been reviewed.
You can assign the PR to them by writing /assign @xiaofan-luan in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@mergify mergify bot added dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement labels Jul 7, 2024
@chyezh chyezh force-pushed the feat_streaming_service_streaming_node_client branch 2 times, most recently from 24637c1 to 6f8ccf5 Compare July 7, 2024 08:53
@mergify mergify bot added the ci-passed label Jul 7, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.91403% with 272 lines in your changes missing coverage. Please review.

Project coverage is 84.38%. Comparing base (c332f69) to head (a9347c7).
Report is 3 commits behind head on master.

❗ Current head a9347c7 differs from pull request most recent head 08f186f

Please upload reports for the commit 08f186f to get more accurate results.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #34467      +/-   ##
==========================================
+ Coverage   80.69%   84.38%   +3.69%     
==========================================
  Files        1127      900     -227     
  Lines      139341   116880   -22461     
==========================================
- Hits       112443    98631   -13812     
+ Misses      22613    13886    -8727     
- Partials     4285     4363      +78
Files Coverage Δ
internal/metastore/catalog.go 100.00% <ø> (ø)
...streamingcoord/server/balancer/channel/pchannel.go 100.00% <100.00%> (ø)
...rnal/streamingcoord/server/balancer/policy/init.go 100.00% <100.00%> (ø)
...oord/server/balancer/policy/pchannel_count_fair.go 100.00% <100.00%> (ø)
internal/streamingcoord/server/balancer/request.go 100.00% <100.00%> (ø)
...nternal/streamingcoord/server/resource/resource.go 100.00% <100.00%> (ø)
...nal/streamingcoord/server/resource/test_utility.go 100.00% <100.00%> (ø)
...er/service/discover/discover_grpc_server_helper.go 100.00% <100.00%> (ø)
...mingnode/client/handler/assignment/watcher_impl.go 100.00% <100.00%> (ø)
...ode/client/handler/producer/produce_grpc_client.go 100.00% <100.00%> (ø)
... and 45 more

... and 312 files with indirect coverage changes
@chyezh chyezh force-pushed the feat_streaming_service_streaming_node_client branch from 6f8ccf5 to a9347c7 Compare July 9, 2024 11:45
@mergify mergify bot added ci-passed and removed ci-passed labels Jul 9, 2024
@chyezh chyezh force-pushed the feat_streaming_service_streaming_node_client branch from a9347c7 to d2e4c38 Compare July 11, 2024 03:14
@mergify mergify bot removed the ci-passed label Jul 11, 2024
@chyezh chyezh force-pushed the feat_streaming_service_streaming_node_client branch from d2e4c38 to 7ccdac6 Compare July 11, 2024 03:29
@chyezh
enhance: streaming service grpc utilities
28ce8d8 
- add two grpc resolver (by session and by streaming coord assignment
service)
- add one grpc balancer (by serverID and roundrobin)
- add lazy conn to avoid block by first service discovery
- add some utility function for streaming service
- fix some bug

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh
enhance: streaming node client implementation
08f186f 
- add streaming node grpc client wrapper
- add unittest for streaming node grpc client side

Signed-off-by: chyezh <chyezh@outlook.com>
@chyezh chyezh force-pushed the feat_streaming_service_streaming_node_client branch from 7ccdac6 to 08f186f Compare July 11, 2024 06:23
@mergify Mergify
Copy link
Contributor

mergify bot commented Jul 11, 2024

@chyezh E2e jenkins job failed, comment /run-cpu-e2e can trigger the job again.
@chyezh
Copy link
Contributor Author

chyezh commented Jul 11, 2024

close to avoid generate extra ci.
@chyezh chyezh closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/compilation dco-passed DCO check passed. kind/enhancement Issues or changes related to enhancement size/XXL Denotes a PR that changes 1000+ lines.
2 participants
@chyezh @sre-ci-robot