enhance: Avoid assign too much segment/channels to new querynode (#34096) #34461
Conversation
mergify
bot
added
dco-passed
|
@weiliu1031 E2e jenkins job failed, comment |
|
@weiliu1031 E2e jenkins job failed, comment |
…vus-io#34096) issue: milvus-io#34095 When a new query node comes online, the segment_checker, channel_checker, and balance_checker simultaneously attempt to allocate segments to it. If this occurs during the execution of a load task and the distribution of the new query node hasn't been updated, the query coordinator may mistakenly view the new query node as empty. As a result, it assigns segments or channels to it, potentially overloading the new query node with more segments or channels than expected. This PR measures the workload of the executing tasks on the target query node to prevent assigning an excessive number of segments to it. --------- Signed-off-by: Wei Liu <wei.liu@zilliz.com>
|
@weiliu1031 ut workflow job failed, comment |
|
rerun ut |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## 2.3 #34461 +/- ##
==========================================
+ Coverage 83.07% 83.10% +0.02%
==========================================
Files 851 851
Lines 107090 107142 +52
==========================================
+ Hits 88969 89036 +67
+ Misses 14807 14791 -16
- Partials 3314 3315 +1
|
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: congqixia, weiliu1031, XuanYang-cn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
issue: #34095
pr: #34096
When a new query node comes online, the segment_checker, channel_checker, and balance_checker simultaneously attempt to allocate segments to it. If this occurs during the execution of a load task and the distribution of the new query node hasn't been updated, the query coordinator may mistakenly view the new query node as empty. As a result, it assigns segments or channels to it, potentially overloading the new query node with more segments or channels than expected.
This PR measures the workload of the executing tasks on the target query node to prevent assigning an excessive number of segments to it.