Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add some sentences about -webkit-line-clamp standard status #34637

Merged
merged 2 commits into from
Jul 5, 2024
Merged

Add some sentences about -webkit-line-clamp standard status #34637

merged 2 commits into from
Jul 5, 2024

Conversation

Josh-Cena
Copy link
Member

Fix #30842. @tannermann does this look good to you?
@Josh-Cena Josh-Cena requested a review from a team as a code owner July 4, 2024 22:24
@Josh-Cena Josh-Cena requested review from chrisdavidmills and removed request for a team July 4, 2024 22:24
@github-actions github-actions bot added Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed labels Jul 4, 2024
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 4, 2024 •
edited
Loading

Preview URLs

Flaws (2)

URL: /en-US/docs/Web/CSS/-webkit-line-clamp
Title: -webkit-line-clamp
Flaw count: 2

  • macros:
    • /en-US/docs/Web/CSS/line-clamp does not exist
    • /en-US/docs/Web/CSS/line-clamp does not exist
External URLs (1)

URL: /en-US/docs/Web/CSS/-webkit-line-clamp
Title: -webkit-line-clamp

(comment last updated: 2024-07-05 16:25:56)
chrisdavidmills
chrisdavidmills approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@chrisdavidmills chrisdavidmills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Josh-Cena approving, but one minor nit for you to consider.
files/en-us/web/css/-webkit-line-clamp/index.md Outdated Show resolved Hide resolved
@Josh-Cena @chrisdavidmills
Update index.md
4350a2e 
Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
@chrisdavidmills chrisdavidmills merged commit 188fe7f into mdn:main Jul 5, 2024
8 checks passed
@Josh-Cena Josh-Cena deleted the webkit-line-clamp branch July 5, 2024 16:45
evelinabe pushed a commit to evelinabe/mdn-content that referenced this pull request Jul 5, 2024
@Josh-Cena @chrisdavidmills @evelinabe
Add some sentences about -webkit-line-clamp standard status (mdn#34637)
9dee488 
* Add some sentences about -webkit-line-clamp standard status

* Update index.md

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>

---------

Co-authored-by: Chris Mills <chrisdavidmills@gmail.com>
tannermann
tannermann reviewed Jul 10, 2024
View reviewed changes
Copy link

@tannermann tannermann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Content:CSS Cascading Style Sheets docs size/xs [PR only] 0-5 LoC changed
4 participants
@Josh-Cena @chrisdavidmills @sideshowbarker @tannermann