Skip to content

Commit

Permalink
Solve conflicts
Browse files Browse the repository at this point in the history
Signed-off-by: Jorge Bescos Gascon <jorge.bescos.gascon@oracle.com>
  • Loading branch information
jbescos committed Feb 23, 2024
2 parents fbc40b5 + 21733cf commit de0fbf4
Show file tree
Hide file tree
Showing 15 changed files with 119 additions and 365 deletions.
12 changes: 8 additions & 4 deletions .github/workflows/maven.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
#
# Copyright (c) 2021 Contributors to the Eclipse Foundation
# Copyright (c) 2021, 2023 Contributors to the Eclipse Foundation
#
# This program and the accompanying materials are made available under the
# terms of the Eclipse Public License v. 2.0 which is available at
Expand All @@ -16,20 +16,24 @@ on:
pull_request:
push:

concurrency:
group: ${{ github.ref }}
cancel-in-progress: true

jobs:
build:
name: Test on JDK ${{ matrix.java_version }}
runs-on: ubuntu-latest

strategy:
matrix:
java_version: [ 11, 17-ea ]
java_version: [ 11, 17, 21 ]

steps:
- name: Checkout for build
uses: actions/checkout@v2.3.4
uses: actions/checkout@v3
- name: Set up JDK
uses: actions/setup-java@v2
uses: actions/setup-java@v3
with:
distribution: 'zulu'
java-version: ${{ matrix.java_version }}
Expand Down
43 changes: 23 additions & 20 deletions api/pom.xml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<?xml version="1.0" encoding="UTF-8"?>
<!--
Copyright (c) 2011, 2022 Oracle and/or its affiliates. All rights reserved.
Copyright (c) 2011, 2023 Oracle and/or its affiliates. All rights reserved.
This program and the accompanying materials are made available under the
terms of the Eclipse Public License v. 2.0, which is available at
Expand All @@ -23,14 +23,14 @@
<parent>
<groupId>org.eclipse.ee4j</groupId>
<artifactId>project</artifactId>
<version>1.0.7</version>
<version>1.0.8</version>
<relativePath/>
</parent>

<groupId>jakarta.json</groupId>
<artifactId>jakarta.json-api</artifactId>

<version>2.1.1-SNAPSHOT</version>
<version>2.1.4-SNAPSHOT</version>
<name>Jakarta JSON Processing API</name>
<description>Jakarta JSON Processing defines a Java(R) based framework for parsing, generating, transforming, and querying JSON documents.</description>
<url>https://github.com/eclipse-ee4j/jsonp</url>
Expand Down Expand Up @@ -83,7 +83,7 @@
<spotbugs.exclude>${project.basedir}/../etc/spotbugs-exclude.xml</spotbugs.exclude>
<spotbugs.skip>false</spotbugs.skip>
<spotbugs.threshold>Low</spotbugs.threshold>
<spotbugs.version>4.3.0</spotbugs.version>
<spotbugs.version>4.7.3.5</spotbugs.version>

<non.final>false</non.final>
<extension.name>jakarta.json</extension.name>
Expand All @@ -95,20 +95,15 @@
<build>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.commonjava.maven.plugins</groupId>
<artifactId>directory-maven-plugin</artifactId>
<version>0.3.1</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>buildnumber-maven-plugin</artifactId>
<version>1.4</version>
<version>3.2.0</version>
</plugin>
<plugin>
<groupId>org.codehaus.mojo</groupId>
<artifactId>build-helper-maven-plugin</artifactId>
<version>3.2.0</version>
<version>3.4.0</version>
</plugin>
<plugin>
<groupId>org.glassfish.copyright</groupId>
Expand All @@ -118,7 +113,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.1</version>
<version>3.11.0</version>
</plugin>
<plugin>
<groupId>org.glassfish.build</groupId>
Expand All @@ -128,7 +123,7 @@
<plugin>
<groupId>org.apache.felix</groupId>
<artifactId>maven-bundle-plugin</artifactId>
<version>5.1.1</version>
<version>5.1.9</version>
<configuration>
<instructions>
<_noextraheaders>true</_noextraheaders>
Expand All @@ -138,22 +133,22 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>3.2.0</version>
<version>3.3.0</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-source-plugin</artifactId>
<version>3.2.1</version>
<version>3.3.0</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-javadoc-plugin</artifactId>
<version>3.3.0</version>
<version>3.5.0</version>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-enforcer-plugin</artifactId>
<version>3.0.0</version>
<version>3.4.0</version>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
Expand Down Expand Up @@ -270,13 +265,12 @@
<artifactId>maven-compiler-plugin</artifactId>
<configuration>
<release>9</release>
<createMissingPackageInfoClass>false</createMissingPackageInfoClass>
<compilerArgs>
<arg>-Xlint:all</arg>
<arg>-Xdoclint:all</arg>
<arg>-Werror</arg>
</compilerArgs>
<showDeprecation>true</showDeprecation>
<showWarnings>true</showWarnings>
</configuration>
<executions>
<execution>
Expand Down Expand Up @@ -337,6 +331,16 @@
!org.eclipse.parsson,
*
</Import-Package>
<!-- optional to allow usage with hk2 resource locator as a fallback -->
<Require-Capability><![CDATA[
osgi.extender;filter:="(&(osgi.extender=osgi.serviceloader.processor)
(version>=1.0.0)(!(version>=2.0.0)))";resolution:=optional,
osgi.serviceloader;
filter:="(osgi.serviceloader=jakarta.json.spi.JsonProvider)";
osgi.serviceloader="jakarta.json.spi.JsonProvider";
cardinality:=multiple;resolution:=optional
]]>
</Require-Capability>
</instructions>
</configuration>
<executions>
Expand Down Expand Up @@ -402,7 +406,6 @@ Use is subject to <a href="{@docRoot}/doc-files/speclicense.html" target="_top">
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<findbugsXmlWithMessages>true</findbugsXmlWithMessages>
<fork>true</fork>
<excludeFilterFile>${spotbugs.exclude}</excludeFilterFile>
<failThreshold>High</failThreshold>
Expand Down
5 changes: 4 additions & 1 deletion api/src/main/java/jakarta/json/EmptyArray.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, 2021 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2017, 2022 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down Expand Up @@ -32,6 +32,9 @@ final class EmptyArray extends AbstractList<JsonValue> implements JsonArray, Ser
/** for serialization */
private static final long serialVersionUID = 7295439472061642859L;

/** Default constructor. */
EmptyArray() {}

@Override
public JsonValue get(int index) {
throw new IndexOutOfBoundsException("Index: " + index);
Expand Down
5 changes: 4 additions & 1 deletion api/src/main/java/jakarta/json/EmptyObject.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2017, 2021 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2017, 2022 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down Expand Up @@ -31,6 +31,9 @@ final class EmptyObject extends AbstractMap<String, JsonValue> implements JsonOb
/** for serialization */
private static final long serialVersionUID = -1461653546889072583L;

/** Default constructor. */
EmptyObject() {}

@Override
public Set<Entry<String, JsonValue>> entrySet() {
return Collections.<Entry<String, JsonValue>>emptySet();
Expand Down
4 changes: 2 additions & 2 deletions api/src/main/java/jakarta/json/Json.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
/*
* Copyright (c) 2011, 2021 Oracle and/or its affiliates. All rights reserved.
* Copyright (c) 2011, 2024 Oracle and/or its affiliates. All rights reserved.
*
* This program and the accompanying materials are made available under the
* terms of the Eclipse Public License v. 2.0, which is available at
Expand Down Expand Up @@ -255,7 +255,7 @@ public static JsonArrayBuilder createArrayBuilder(JsonArray array) {

/**
* Creates a JSON array builder, initialized with the content of specified {@code collection}.
* If the @{code collection} contains {@link Optional}s then resulting JSON array builder
* If the {@code collection} contains {@link Optional}s then resulting JSON array builder
* contains the value from the {@code collection} only if the {@link Optional} is not empty.
*
* @param collection the initial data for the builder
Expand Down
Loading

0 comments on commit de0fbf4

Please sign in to comment.