Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: don't use filesystem for group aliases #7556

Merged
merged 8 commits into from
Jun 18, 2024

Conversation

jennifer-richards
Copy link
Member

This one is performant enough I don't think caching is needed.

Copy link

codecov bot commented Jun 18, 2024

Codecov Report

Attention: Patch coverage is 94.73684% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.93%. Comparing base (187c2c5) to head (70aa17c).
Report is 246 commits behind head on main.

Current head 70aa17c differs from pull request most recent head 068cf1a

Please upload reports for the commit 068cf1a to get more accurate results.

Files Patch % Lines
ietf/group/utils.py 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7556      +/-   ##
==========================================
- Coverage   88.98%   88.93%   -0.06%     
==========================================
  Files         291      295       +4     
  Lines       40717    41231     +514     
==========================================
+ Hits        36233    36668     +435     
- Misses       4484     4563      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

rjsparks
rjsparks previously approved these changes Jun 18, 2024
@rjsparks rjsparks merged commit 0ac2ae1 into ietf-tools:main Jun 18, 2024
7 checks passed
@jennifer-richards jennifer-richards deleted the no-group-alias-checks branch June 18, 2024 13:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants