Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: make WG summary view into a task #7529

Merged
merged 9 commits into from
Jun 14, 2024

Conversation

jennifer-richards
Copy link
Member

This moves the work in the wg_summary_by_area and wg_summary_by_acronym views into the new generate_wg_summary_files_task(). The views are refactored to pass the file through instead of generating it on request.

The old views were used by Night-runner and run nightly. I've made these hourly instead because the task is not terribly expensive and this matches the handling of the WG charter file generation. It's easy to change it to daily, though.

Generating these files is fast enough we could refactor further and generate the files both in a task and in the view instead of doing the file pass-through. For the charter files, we had caching in place that meant we were effectively serving the generated files anyway. For the summary files, there was no such caching so this is more of a change. Unless there's a strong need for it, though, I'd rather keep these views the same.

Fixes https://github.com/ietf-tools/infra-cloud/issues/204

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.93%. Comparing base (187c2c5) to head (6be04dd).
Report is 237 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7529      +/-   ##
==========================================
- Coverage   88.98%   88.93%   -0.06%     
==========================================
  Files         291      295       +4     
  Lines       40717    41235     +518     
==========================================
+ Hits        36233    36672     +439     
- Misses       4484     4563      +79     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks rjsparks merged commit 4e6abcb into ietf-tools:main Jun 14, 2024
9 checks passed
@jennifer-richards jennifer-richards deleted the summarily-celerized branch June 14, 2024 20:56
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants