-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: use surname/initials for author name #7510
Conversation
Looks good to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One question inline before approving
{% for author in submission.authors %} | ||
<button type="button" | ||
class="author btn btn-primary mb-3" | ||
data-name="{{ author.name }}" | ||
data-email="{% if author.email %}{{ author.email }}{% endif %}"> | ||
{{ author.name }} | ||
</button> | ||
{% if author.name %} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if author.name is None for all authors in submission.authors, does the form fail?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, these buttons are just present to quick-fill the actual form field via javascript. If there are no buttons, then the submitter has to fill in the fields manually.
This adds logic similar to what is used in xml2rfc's
TextWriter
to render an author name from theinitials
and/orsurname
fields whenfullname
is not present.I've also updated places where we display the name to account for the possibility that the name is absent. If possible, I show the affiliation instead. This again matches what
TextWriter
does when rendering an RFC.@russhousley