-
Notifications
You must be signed in to change notification settings - Fork 319
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Formatting blockquotes in datatrackers rendered markdown #7500
fix: Formatting blockquotes in datatrackers rendered markdown #7500
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7500 +/- ##
==========================================
- Coverage 88.98% 88.92% -0.07%
==========================================
Files 291 295 +4
Lines 40717 41224 +507
==========================================
+ Hits 36233 36657 +424
- Misses 4484 4567 +83 ☔ View full report in Codecov by Sentry. |
This gets one place where we are rendering markdown - would be format all the places. |
@rjsparks which other ones should be updated? All the document_ballot_content.html document_draft.html document_material.html document_status_change.html
document_ballot.html document_email.html document_polls.html document_subseries.html
document_bibtex.bib document_format_buttons.html document_referenced_by.html document_subseries_top.html
document_bofreq.html document_history_form.html document_references.html document_top.html
document_charter.html document_history.html document_review.html document_writeup.html
document_chatlog.html document_html.html document_rfc.html
document_conflict_review.html document_info.html document_statement.html |
@@ -121,7 +121,7 @@ | |||
<div class="card-header"> | |||
{{ doc.name }}-{{ doc.rev }} | |||
</div> | |||
<div class="card-body text-break"> | |||
<div class="card-body text-break richtext"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
richtext can go away again, yes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, done
@rjsparks Because we're changing the default formatting of |
Yes - some of those pages are crufty and may need to move out of the datatracker into another property or just go away. |
This adds a utility class for HTML blobs of content (ie dynamic content...content that we can't add classes) to format
<blockquote>
.In the following example the "text" is a blockquote which has
padding-left
andborder-left
:Fixes https://github.com/orgs/ietf-tools/projects/3/views/4?pane=issue&itemId=58443314