Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Formatting blockquotes in datatrackers rendered markdown #7500

Merged
merged 3 commits into from
Jun 6, 2024

Conversation

holloway
Copy link
Contributor

@holloway holloway commented Jun 4, 2024

This adds a utility class for HTML blobs of content (ie dynamic content...content that we can't add classes) to format <blockquote>.

In the following example the "text" is a blockquote which has padding-left and border-left:

Screenshot from 2024-06-04 13-37-00

Fixes https://github.com/orgs/ietf-tools/projects/3/views/4?pane=issue&itemId=58443314

@holloway holloway requested a review from rjsparks June 4, 2024 01:40
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.92%. Comparing base (187c2c5) to head (649a404).
Report is 232 commits behind head on main.

Current head 649a404 differs from pull request most recent head 879a81f

Please upload reports for the commit 879a81f to get more accurate results.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7500      +/-   ##
==========================================
- Coverage   88.98%   88.92%   -0.07%     
==========================================
  Files         291      295       +4     
  Lines       40717    41224     +507     
==========================================
+ Hits        36233    36657     +424     
- Misses       4484     4567      +83     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjsparks
Copy link
Member

rjsparks commented Jun 4, 2024

This gets one place where we are rendering markdown - would be format all the places.

@holloway
Copy link
Contributor Author

holloway commented Jun 4, 2024

@rjsparks which other ones should be updated? All the document_* templates?

document_ballot_content.html   document_draft.html           document_material.html       document_status_change.html
document_ballot.html           document_email.html           document_polls.html          document_subseries.html
document_bibtex.bib            document_format_buttons.html  document_referenced_by.html  document_subseries_top.html
document_bofreq.html           document_history_form.html    document_references.html     document_top.html
document_charter.html          document_history.html         document_review.html         document_writeup.html
document_chatlog.html          document_html.html            document_rfc.html
document_conflict_review.html  document_info.html            document_statement.html
@@ -121,7 +121,7 @@
<div class="card-header">
{{ doc.name }}-{{ doc.rev }}
</div>
<div class="card-body text-break">
<div class="card-body text-break richtext">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

richtext can go away again, yes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, done

@rjsparks rjsparks merged commit c1f1e1b into ietf-tools:main Jun 6, 2024
7 checks passed
@holloway
Copy link
Contributor Author

holloway commented Jun 6, 2024

@rjsparks Because we're changing the default formatting of <blockquote> to have a border-left I updated all the existing blockquotes to render without a border with those inline style="border-left: 0". Arguably those should just be <div>s for semantic reasons but I guess that can happen in another PR

@rjsparks
Copy link
Member

rjsparks commented Jun 6, 2024

Yes - some of those pages are crufty and may need to move out of the datatracker into another property or just go away.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants