fix: Scroll metadata sidebar tab content #7499
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7499 +/- ##
==========================================
- Coverage 88.98% 88.92% -0.07%
==========================================
Files 291 295 +4
Lines 40717 41224 +507
==========================================
+ Hits 36233 36658 +425
- Misses 4484 4566 +82 ☔ View full report in Codecov by Sentry. |
|
About #e3cba5e ...some browsers/platforms don't allocate space for scrollbars (ie they have zero-width scrollbars that only float above the page) which means two scrollbars could render ontop of each other. This adds some additional spacing. |
|
This looks good to me - Martin and Lars have had time to comment. I'll merge this in and it will be part of the next release (which might be tomorrow). |
rjsparks
approved these changes
Jun 6, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at addressing #7390 which looks like,
Chrome
Firefox
For UX reasons just the tab content in the sidebar has been made scrollable. Is that ok? The UX reason are that if the sidebar had a full scrollbar it would look like the page itself had 2 scrollbars, whereas this is more clearly just making the tab content scrollable. This does mean that very short screens might not have enough visible scrolling area but such a small screen is probably mobile/tablet which needs a different responsive approach anyway.
Thoughts?
@larseggert @martinthomson