Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run unit tests with default chooseAddressMappingPolicy and fix DenseStrategy bug #1419

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

sequba
Copy link
Contributor

@sequba sequba commented Jul 3, 2024

Context

The test config was wrong therefore we missed that bug. Now both the test config and the bug are fixed.

How did you test your changes?

  • unit tests pass
  • new unit tests

Types of changes

  • Breaking change (a fix or a feature because of which an existing functionality doesn't work as expected anymore)
  • New feature or improvement (a non-breaking change that adds functionality)
  • Bug fix (a non-breaking change that fixes an issue)
  • Additional language file, or a change to an existing language file (translations)
  • Change to the documentation

Related issues:

Fixes #1406

Checklist:

  • I have reviewed the guidelines about Contributing to HyperFormula and I confirm that my code follows the code style of this project.
  • I have signed the Contributor License Agreement.
  • My change is compliant with the OpenDocument standard.
  • My change is compatible with Microsoft Excel.
  • My change is compatible with Google Sheets.
  • I described my changes in the CHANGELOG.md file.
  • My changes require a documentation update.
  • My changes require a migration guide.
Copy link

github-actions bot commented Jul 3, 2024

Performance comparison of head (2a3c47a) vs base (1701331)

                                     testName |   base |   head | change
------------------------------------------------------------------------
                                      Sheet A | 501.15 | 507.89 | +1.34%
                                      Sheet B | 164.71 | 165.92 | +0.73%
                                      Sheet T | 143.88 | 147.04 | +2.20%
                                Column ranges | 496.14 |  499.7 | +0.72%
Sheet A:  change value, add/remove row/column |  13.88 |  13.58 | -2.16%
 Sheet B: change value, add/remove row/column | 132.16 |  131.1 | -0.80%
                   Column ranges - add column | 139.96 | 146.55 | +4.71%
                Column ranges - without batch | 427.93 | 446.05 | +4.23%
                        Column ranges - batch | 126.79 | 124.55 | -1.77%
@sequba sequba changed the title Run unit tests with default chooseAddressMappingPolicy and fix DenseStartegy bug Jul 9, 2024
@sequba sequba marked this pull request as ready for review July 10, 2024 08:36
@sequba sequba requested a review from evanSe July 10, 2024 08:37
@sequba sequba merged commit d44bf8e into develop Jul 11, 2024
21 checks passed
@sequba sequba deleted the feature/issue-1406 branch July 11, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants