Added enter handler for textbox #372 #2355
Open
+16
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mturoci
requested changes
Jun 24, 2024
There was a problem hiding this comment.
Thanks @haneenabdo! Can you pleases also include unit tests and a video demo of how your changes work in practice?
Comment on lines
+15
to
+20
| "paths": { | ||
| "@fluentui/react": ["node_modules/@fluentui/react"] | ||
| }, | ||
| "jsx": "preserve", | ||
| "esModuleInterop": true, | ||
| "include": ["src", "node_modules/@types"], |
Comment on lines
+70
to
+71
| /**T rue if the Enter button is being pressed */ | ||
| onEnter?: B |
There was a problem hiding this comment.
We should probably do this by default, no need for an extra prop.
|
I would be really happy if this PR would be committed, as I also really need the feature, that pressing Enter in a textbox will call the handler (do something with the contents). An additional button just for this is really not what the people will expect and slow in our environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #372
The PR fulfills these requirements: (check all the apply)
mainbranch.feat: Add a button #xxx, where "xxx" is the issue number).Closes #xxx, where "xxx" is the issue number.uifolder, unit tests (make test) still pass.