Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: unmanaged dependency check #1521

Merged
merged 2 commits into from
Jan 26, 2024
Merged

ci: unmanaged dependency check #1521

merged 2 commits into from
Jan 26, 2024

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jan 25, 2024

Cindy has reviewed go/cloud-sdk-java-dependency-governance-design. This new check would fail if someone adds an unknown new dependency to pom.xml files. All new dependencies should be added in https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/third-party-dependencies/pom.xml first.

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: logging Issues related to the googleapis/java-logging API. labels Jan 25, 2024
@suztomo
Copy link
Member Author

suztomo commented Jan 25, 2024

Unmanaged dependency check / unmanaged_dependency_check (pull_request) Successful

@suztomo
Copy link
Member Author

suztomo commented Jan 25, 2024

@cindy-peng This is the check discussed in go/cloud-sdk-java-dependency-governance-design and we are gradually rolling out to the repositories. PTAL.

@suztomo suztomo marked this pull request as ready for review January 25, 2024 22:00
@suztomo suztomo requested review from a team as code owners January 25, 2024 22:00
@suztomo suztomo added the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jan 26, 2024
Copy link
Contributor

@cindy-peng cindy-peng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Tomo for working on this!

@suztomo suztomo merged commit 7926233 into main Jan 26, 2024
23 checks passed
@suztomo suztomo deleted the unmanaged_dependencies_check branch January 26, 2024 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.
2 participants