Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Fix typo in code comments #1520

Merged
merged 2 commits into from
Feb 5, 2024
Merged

docs: Fix typo in code comments #1520

merged 2 commits into from
Feb 5, 2024

Conversation

cindy-peng
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@cindy-peng cindy-peng requested review from a team as code owners January 25, 2024 20:41
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: logging Issues related to the googleapis/java-logging API. labels Jan 25, 2024
@cindy-peng cindy-peng changed the title fix: Fix type in code comments Jan 25, 2024
@product-auto-label product-auto-label bot added size: s Pull request size is small. and removed size: xs Pull request size is extra small. labels Jan 25, 2024
@kolea2 kolea2 changed the title fix: Fix typo in code comments Feb 5, 2024
@kolea2
Copy link
Contributor

kolea2 commented Feb 5, 2024

nit (I updated in this PR) - please prefix these types of changes as "docs" rather than "fix", otherwise it will show up as a bug fix in the release notes

@cindy-peng cindy-peng merged commit 0440fc6 into main Feb 5, 2024
22 checks passed
@cindy-peng cindy-peng deleted the cindy/fix-typo branch February 5, 2024 19:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: logging Issues related to the googleapis/java-logging API. size: s Pull request size is small.
2 participants