Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] fix: clean up the residual artifact trash #20712

Closed
wants to merge 1 commit into from

Conversation

chlins
Copy link
Member

@chlins chlins commented Jul 8, 2024

Clean up the residual artifact trash and related artifact blob, manifest when in the large number of artifact trash.

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #20711

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
Clean up the residual artifact trash and related artifact blob, manifest
when in the large number of artifact trash.

Signed-off-by: chlins <chlins.zhang@gmail.com>
@chlins chlins requested a review from a team as a code owner July 8, 2024 07:37
Copy link

codecov bot commented Jul 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 16 lines in your changes missing coverage. Please review.

Project coverage is 66.26%. Comparing base (c8c11b4) to head (134fe8b).
Report is 239 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20712       +/-   ##
===========================================
+ Coverage   45.36%   66.26%   +20.89%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113532   +100199     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75228    +69179     
- Misses       6983    34193    +27210     
- Partials      301     4111     +3810     
Flag Coverage Δ
unittests 66.26% <66.66%> (+20.89%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/jobservice/job/impl/gc/garbage_collection.go 47.80% <66.66%> (ø)

... and 1286 files with indirect coverage changes

@chlins chlins closed this Jul 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
4 participants