Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gorilla/mux reorganize #20709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gorilla/mux reorganize #20709

wants to merge 2 commits into from

Conversation

Its-Maniaco
Copy link

Reorganized all the references of gorilla/mux into seperate file for each package

Partial Fix #19965
@Its-Maniaco Its-Maniaco requested a review from a team as a code owner July 7, 2024 10:55
@Its-Maniaco
partial reorganize of jobservicem, registryctl
fe3d8b1 
Signed-off-by: Its-Maniaco <21123621+Its-Maniaco@users.noreply.github.com>
@Its-Maniaco
seperated gorilla/mux into different files
18cb1fa 
Signed-off-by: Its-Maniaco <21123621+Its-Maniaco@users.noreply.github.com>
@Its-Maniaco
Copy link
Author

Its-Maniaco commented Jul 7, 2024 •
edited
Loading

@chlins @Vad1mo based on my understanding I made these changes.
There is a bit of code that I reused in different files. Should I create a separate package for gorilla/mux related code or is there any other alternative you would recommend?
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants
@Its-Maniaco @wy65701436 @zyyw @chlins @MinerYang