Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Parallel attach ldap group #20705

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Parallel attach ldap group #20705

wants to merge 1 commit into from

Conversation

stonezdj
Copy link
Contributor

@stonezdj stonezdj commented Jul 5, 2024

Add configure LDAP group attach parallel UI
Change the /c/login timeout from 60 (nginx default) to 900 seconds in nginx.conf

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
@stonezdj stonezdj requested a review from a team as a code owner July 5, 2024 02:29
@stonezdj stonezdj requested a review from reasonerjt July 5, 2024 02:29
@stonezdj stonezdj requested a review from wy65701436 July 5, 2024 02:30
@stonezdj stonezdj added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label Jul 5, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 8, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 8.45070% with 65 lines in your changes missing coverage. Please review.

Project coverage is 66.23%. Comparing base (b7b8847) to head (cebff02).
Report is 240 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20705      +/-   ##
==========================================
- Coverage   67.56%   66.23%   -1.33%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113585    +4404     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75233    +1465     
- Misses      31449    34243    +2794     
- Partials     3964     4109     +145
Flag Coverage Δ
unittests 66.23% <8.45%> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/lib/config/models/model.go 100.00% <ø> (ø)
src/lib/config/userconfig.go 66.88% <100.00%> (-1.10%) ⬇️
src/core/auth/ldap/ldap.go 37.45% <7.14%> (-9.38%) ⬇️

... and 572 files with indirect coverage changes
@stonezdj stonezdj force-pushed the 24jul01_ldap_group_perf branch 3 times, most recently from ee269fc to 88dc5bc Compare July 8, 2024 05:27
wy65701436
wy65701436 reviewed Jul 8, 2024
View reviewed changes
api/v2.0/swagger.yaml Outdated Show resolved Hide resolved
@stonezdj
Parallel attach LDAP group
cebff02 
  Add configure LDAP group attach parallel UI
  Change the /c/login timeout from 60 (nginx default) to 900 seconds in nginx.conf

Signed-off-by: stonezdj <stone.zhang@broadcom.com>
wy65701436
wy65701436 approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/enhancement Label to mark PR to be added under release notes as enhancement
7 participants
@stonezdj @reasonerjt @wy65701436 @zyyw @OrlinVasilev @AllForNothing @MinerYang