Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[cherry-pick] fix: add quote to dockerhub cred #20694

Merged
merged 1 commit into from
Jul 15, 2024
Merged

[cherry-pick] fix: add quote to dockerhub cred #20694

merged 1 commit into from
Jul 15, 2024

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jul 4, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
@zyyw zyyw requested a review from a team as a code owner July 4, 2024 05:29
@zyyw zyyw added release-note/ignore-for-release Do not include PR or Issue for release notes release-note/infra Infra related changes e.g. release, test, ship etc... labels Jul 4, 2024
@codecov Codecov
Copy link

codecov bot commented Jul 4, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (release-2.11.0@82c9f9c). Learn more about missing BASE report.

Additional details and impacted files

Impacted file tree graph

@@                Coverage Diff                @@
##             release-2.11.0   #20694   +/-   ##
=================================================
  Coverage                  ?   66.24%           
=================================================
  Files                     ?     1045           
  Lines                     ?   113486           
  Branches                  ?     2845           
=================================================
  Hits                      ?    75182           
  Misses                    ?    34195           
  Partials                  ?     4109
Flag Coverage Δ
unittests 66.24% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.
@zyyw
fix: add quote to dockerhub cred in case it contains specical characters
8cee35b 
which will be failed to run the publish release github action job
regarding publishImages

Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw force-pushed the cp-2.11.0-quote-dockerhub-cred branch from 52c9d0d to 8cee35b Compare July 4, 2024 05:39
@zyyw zyyw changed the title fix: add quote to dockerhub cred Jul 4, 2024
chlins
chlins approved these changes Jul 4, 2024
View reviewed changes
Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
MinerYang
MinerYang approved these changes Jul 15, 2024
View reviewed changes
Copy link
Contributor

@MinerYang MinerYang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm
@zyyw zyyw merged commit 14f98c0 into goharbor:release-2.11.0 Jul 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes release-note/infra Infra related changes e.g. release, test, ship etc...
6 participants
@zyyw @chlins @MinerYang @stonezdj @wy65701436 @OrlinVasilev