Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add quote to dockerhub cred #20693

Merged
merged 3 commits into from
Jul 15, 2024
Merged

Conversation

zyyw
Copy link
Contributor

@zyyw zyyw commented Jul 4, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Issue being fixed

Fixes #(issue)

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
Signed-off-by: Shengwen Yu <yshengwen@vmware.com>
@zyyw zyyw added release-note/ignore-for-release Do not include PR or Issue for release notes release-note/infra Infra related changes e.g. release, test, ship etc... labels Jul 4, 2024
@zyyw zyyw requested a review from a team as a code owner July 4, 2024 03:43
Copy link

codecov bot commented Jul 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (c8c11b4) to head (5f00e38).
Report is 240 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20693       +/-   ##
===========================================
+ Coverage   45.36%   66.24%   +20.87%     
===========================================
  Files         244     1045      +801     
  Lines       13333   113501   +100168     
  Branches     2719     2845      +126     
===========================================
+ Hits         6049    75186    +69137     
- Misses       6983    34203    +27220     
- Partials      301     4112     +3811     
Flag Coverage Δ
unittests 66.24% <ø> (+20.87%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1287 files with indirect coverage changes

Copy link
Contributor

@wy65701436 wy65701436 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@chlins chlins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@zyyw zyyw merged commit 753c765 into goharbor:main Jul 15, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note/ignore-for-release Do not include PR or Issue for release notes release-note/infra Infra related changes e.g. release, test, ship etc...
7 participants