Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #20658 docker-compose version is obsolete warning #20659

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

jhdxr
Copy link

@jhdxr jhdxr commented Jun 25, 2024

Comprehensive Summary of your change

This is PR removed the obsoleted global level version from the docker compose template.

Issue being fixed

Fixes #20658

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
@jhdxr jhdxr requested a review from a team as a code owner June 25, 2024 07:30
@jhdxr
Copy link
Author

jhdxr commented Jun 25, 2024

I don't think I have the permission to label this PR. or maybe there is robot can help me to do so? It's not mentioned in the CONTRIBUTING.md

Copy link

codecov bot commented Jun 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.23%. Comparing base (b7b8847) to head (f7ff6e6).
Report is 233 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20659      +/-   ##
==========================================
- Coverage   67.56%   66.23%   -1.33%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113477    +4296     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75166    +1398     
- Misses      31449    34204    +2755     
- Partials     3964     4107     +143     
Flag Coverage Δ
unittests 66.23% <ø> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 571 files with indirect coverage changes

@MinerYang
Copy link
Contributor

Please confirm it work with legacy docker-compose version ,
Thx~

@jhdxr
Copy link
Author

jhdxr commented Jul 1, 2024

Please confirm it work with legacy docker-compose version , Thx~

Can I check what's the minimun version we need to support?

Signed-off-by: 蝦米 <me@jhdxr.com>
@MinerYang
Copy link
Contributor

MinerYang commented Jul 5, 2024

Please confirm it work with legacy docker-compose version , Thx~

Can I check what's the minimun version we need to support?

We need at least:

  • docker-compose (v1.18.0+) or docker compose v2 (docker-compose-plugin)
  • docker engine Version 20.10.10-ce+ or higher
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
5 participants