Reduce image size #20640
Open
Reduce image size #20640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do following actions to reduce the size of the generated images. - Change `COPY` command + `chown`/`chmod` command to `COPY` command + `--chown`/`--chmod` option. To prevent both files before/after `chown`/`chmod` commands from being recorded on different layers. - Put all `tdnf` commands in a single `RUN` command and move `tdnf clean all` command to the end. To prevent the `tdnf` cache from being recorded on a layer, and the `tdnf` database from being recorded on multiple layers. - Add `--link` option to `COPY` command. This does not contribute to image size reduction, but makes image building more efficient. - Move `chown /etc/pki/tls/certs` to the `Dockerfile.base`. This does not contribute to image size reduction, but is used in conjunction with `COPY --link` to make image building more efficient. The target images and their sizes are as follows. (The sizes are the value when built locally) - harbor-core : 185MB -> 118MB - harbor-db : 285MB -> 263MB - harbor-exporter : 108MB -> 79.1MB - harbor-jobservice : 159MB -> 105MB - harbor-registryctl : 160MB -> 104MB - redis-photon : 179MB -> 170 MB - standalone-db-migrator : 328MB -> 284MB Note that harbor-log, harbor-portal, and nginx-photon have almost no effect, and prepare is not directly executed by the user, so they are not included. Also, registry-photon and trivy-adapter-photon are not included, since PR#20622 and PR#20623 include equivalent action for these two, respectively. Signed-off-by: Mitsuru Kariya <mitsuru.kariya@nttdata.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #20640 +/- ##
===========================================
+ Coverage 45.36% 66.23% +20.86%
===========================================
Files 244 1045 +801
Lines 13333 113501 +100168
Branches 2719 2845 +126
===========================================
+ Hits 6049 75179 +69130
- Misses 6983 34211 +27228
- Partials 301 4111 +3810
Flags with carried forward coverage won't be shown. Click here to find out more. |
Vad1mo
added
the
release-note/infra
Vad1mo
approved these changes
Jun 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Comprehensive Summary of your change
Do following actions to reduce the size of the generated images.
COPYcommand +chown/chmodcommand toCOPYcommand +--chown/--chmodoption. To prevent both files before/afterchown/chmodcommands from being recorded on different layers.tdnfcommands in a singleRUNcommand and movetdnf clean allcommand to the end. To prevent thetdnfcache from being recorded on a layer, and thetdnfdatabase from being recorded on multiple layers.--linkoption toCOPYcommand. This does not contribute to image size reduction, but makes image building more efficient.chown /etc/pki/tls/certsto theDockerfile.base. This does not contribute to image size reduction, but is used in conjunction withCOPY --linkto make image building more efficient.The target images and their sizes are as follows. (The sizes are the value when built locally)
Note that harbor-log, harbor-portal, and nginx-photon have almost no effect, and prepare is not directly executed by the user, so they are not included.
Also, registry-photon and trivy-adapter-photon are not included, since PR #20622 and PR #20623 include equivalent action for these two, respectively.
Issue being fixed
Please indicate you've done the following: