Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make it possible to build the spectral image also on ARM #20506

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

Vad1mo
Copy link
Member

@Vad1mo Vad1mo commented May 28, 2024

Local image build for ARM CPU Architecture

This change makes it possible to build the spectra image not only for the x86 architecture but also for ARM.
This also updates SPECTRAL_VERSION to 6.11.1 because 6.1 does not provide binaries apart from x86.

The main problem this fix solves is that users can better develop and compile Harbor locally on ARM systems.

Issue being resolved

Fixes various issues on building and running Harbor locally on ARM
https://github.com/goharbor/harbor/issues?q=is%3Aissue+ARM

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
@Vad1mo Vad1mo requested a review from a team as a code owner May 28, 2024 22:49
@Vad1mo Vad1mo added the release-note/enhancement Label to mark PR to be added under release notes as enhancement label May 28, 2024
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 66.24%. Comparing base (b7b8847) to head (91c0b15).
Report is 233 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #20506      +/-   ##
==========================================
- Coverage   67.56%   66.24%   -1.33%     
==========================================
  Files         991     1045      +54     
  Lines      109181   113489    +4308     
  Branches     2719     2845     +126     
==========================================
+ Hits        73768    75177    +1409     
- Misses      31449    34202    +2753     
- Partials     3964     4110     +146     
Flag Coverage Δ
unittests 66.24% <ø> (-1.33%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 572 files with indirect coverage changes

Signed-off-by: Vadim Bauer <vb@container-registry.com>
@Vad1mo Vad1mo enabled auto-merge (squash) June 29, 2024 13:39
Signed-off-by: Vadim Bauer <vb@container-registry.com>
@Vad1mo Vad1mo force-pushed the fix/build_spectral_on_arm branch from 81db8f1 to 65ccf4a Compare June 29, 2024 13:49
Signed-off-by: Vadim Bauer <vb@container-registry.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
candidate/2.12.0 release-note/enhancement Label to mark PR to be added under release notes as enhancement
5 participants