Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sig icons for artifact detail page #20494

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MinerYang
Copy link
Contributor

@MinerYang MinerYang commented May 28, 2024

Thank you for contributing to Harbor!

Comprehensive Summary of your change

Will add this as a follow-up PR in v2.12 since would like to add an option as withIcon to avoid performance issue.

Issue being fixed

Fixes #20485

Please indicate you've done the following:

  • Well Written Title and Summary of the PR
  • Label the PR as needed. "release-note/ignore-for-release, release-note/new-feature, release-note/update, release-note/enhancement, release-note/community, release-note/breaking-change, release-note/docs, release-note/infra, release-note/deprecation"
  • Accepted the DCO. Commits without the DCO will delay acceptance.
  • Made sure tests are passing and test coverage is added if needed.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed in website repository.
@MinerYang MinerYang added the release-note/update Update or Fix label May 28, 2024
@MinerYang MinerYang requested a review from a team as a code owner May 28, 2024 02:55
Copy link

codecov bot commented May 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 46.18%. Comparing base (b7b8847) to head (a9af348).
Report is 200 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main   #20494       +/-   ##
===========================================
- Coverage   67.56%   46.18%   -21.38%     
===========================================
  Files         991      247      -744     
  Lines      109181    13770    -95411     
  Branches     2719     2842      +123     
===========================================
- Hits        73768     6360    -67408     
+ Misses      31449     7082    -24367     
+ Partials     3964      328     -3636     
Flag Coverage Δ
unittests 46.18% <ø> (-21.38%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1238 files with indirect coverage changes

@MinerYang MinerYang force-pushed the fix_icon_for_accessory_details branch 2 times, most recently from 521ae11 to 1118373 Compare May 28, 2024 04:18
@MinerYang MinerYang force-pushed the fix_icon_for_accessory_details branch from 1118373 to 7bbf0b7 Compare May 28, 2024 05:49
Signed-off-by: yminer <yminer@vmware.com>

update testing mock func ListAccByArtId

fix lint

update UT

set populate icon as an option
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment