Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Map Firebase FIREBASE_STORAGE_EMULATOR_HOST to the Cloud API STORAGE_EMULATOR_HOST #588

Merged
merged 4 commits into from
Oct 3, 2023
Merged

fix: Map Firebase FIREBASE_STORAGE_EMULATOR_HOST to the Cloud API STORAGE_EMULATOR_HOST #588

merged 4 commits into from
Oct 3, 2023

Conversation

jonathanedey
Copy link
Contributor

Map Firebase FIREBASE_STORAGE_EMULATOR_HOST to the Cloud API STORAGE_EMULATOR_HOST environment variable to properly acknowledge storage emulation.
@jonathanedey jonathanedey linked an issue Oct 2, 2023 that may be closed by this pull request
SDK doesn't honor FIREBASE_STORAGE_EMULATOR_HOST environment variable #520
Closed
@jonathanedey jonathanedey self-assigned this Oct 2, 2023
@jonathanedey jonathanedey marked this pull request as ready for review October 2, 2023 19:29
lahirumaramba
lahirumaramba approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Left one comment. Thanks!
storage/storage_test.go Show resolved Hide resolved
@jonathanedey jonathanedey merged commit 96101fd into dev Oct 3, 2023
8 checks passed
@jonathanedey jonathanedey deleted the je-storage-emulator branch October 3, 2023 17:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage release-note
2 participants
@jonathanedey @lahirumaramba