Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): MFA Support for GoLang createUser, updateUser #511

Merged
merged 8 commits into from
Nov 9, 2022

Conversation

pragatimodi
Copy link
Contributor

No description provided.

auth/user_mgt.go Outdated Show resolved Hide resolved
auth/user_mgt.go Outdated Show resolved Hide resolved
auth/user_mgt.go Outdated Show resolved Hide resolved
auth/user_mgt.go Outdated Show resolved Hide resolved
auth/user_mgt_test.go Show resolved Hide resolved
auth/user_mgt_test.go Outdated Show resolved Hide resolved
auth/user_mgt_test.go Outdated Show resolved Hide resolved
@pragatimodi pragatimodi changed the base branch from master to dev October 4, 2022 21:01
Copy link

@prameshj prameshj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add integration tests for create and update user. Once that's done and the comments here are addressed, feel free to get review from @lahirumaramba and submit. Thanks!

auth/user_mgt.go Outdated Show resolved Hide resolved
auth/user_mgt.go Outdated Show resolved Hide resolved
auth/user_mgt.go Outdated Show resolved Hide resolved
auth/user_mgt.go Outdated Show resolved Hide resolved
auth/user_mgt_test.go Outdated Show resolved Hide resolved
auth/user_mgt.go Outdated Show resolved Hide resolved
@lahirumaramba lahirumaramba changed the title MFA Support for GoLang createUser, updateUser Oct 28, 2022
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! LGTM!

auth/user_mgt.go Show resolved Hide resolved
auth/user_mgt.go Show resolved Hide resolved
@lahirumaramba
Copy link
Member

Adding @kevinthecheung to review the reference doc changes. Thank you!

@brokeyourbike
Copy link
Contributor

Hi @lahirumaramba @kevinthecheung , when do you think this can be merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
6 participants