Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(auth): Change "MemoryCost" to "cpuMemCost" in StandardScrypt type #508

Merged
merged 13 commits into from
Sep 8, 2022
Merged

fix(auth): Change "MemoryCost" to "cpuMemCost" in StandardScrypt type #508

merged 13 commits into from
Sep 8, 2022

Conversation

pragatimodi
Copy link
Contributor

@pragatimodi pragatimodi commented Aug 25, 2022 •
edited by lahirumaramba
Loading

Changing the key value "MemoryCost" returned from hash.StandardScrypt.Config() to "cpuMemCost"

RELEASE NOTE: Fixed an incorrect key used to set MemoryCost config in hash.StandardScrypt.Config() API
@prameshj
Copy link

/lgtm
@prameshj
Copy link

cc @lahirumaramba
@lahirumaramba
Copy link
Member

Hi @pragatimodi Thank you for the PR! Would you be able to change the base to dev, please?
@pragatimodi pragatimodi changed the base branch from master to dev September 6, 2022 17:51
lahirumaramba
lahirumaramba approved these changes Sep 6, 2022
View reviewed changes
Copy link
Member

@lahirumaramba lahirumaramba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM!
@lahirumaramba lahirumaramba merged commit f6f1f7c into firebase:dev Sep 8, 2022
@lahirumaramba lahirumaramba mentioned this pull request Sep 14, 2022
Closed
@lahirumaramba lahirumaramba changed the title Bug fix #489 Sep 28, 2022
@lahirumaramba lahirumaramba changed the title fix(auth): Changing variable from "MemoryCost" to "cpuMemCost" in StandardScrypt type Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note
4 participants
@pragatimodi @prameshj @lahirumaramba @google-oss-bot