Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bumped minimum go version to 1.15 #485

Merged
merged 3 commits into from
Mar 4, 2022
Merged

Conversation

lahirumaramba
Copy link
Member

  • Supporting the latest go version (1.17) and 2 previous as per policy.
  • Restricting build matrix to the oldest and latest go versions we support (1.15 to 1.17).

RELEASE NOTE: Dropped support for Go 1.11 to 1.14. Go Admin SDK now requires Go 1.15 or higher.

README.md Outdated
@@ -41,9 +41,10 @@ requests, code review feedback, and also pull requests.

## Supported Go Versions

We support Go v1.12 and higher.
Admin Go SDK is compatible with at least the three most recent, major Go releases.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Truly a nit, but "The Admin Go SDK" reads a little nicer.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks! Updated.

Copy link

@egilmorez egilmorez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG Lahiru, thanks!

@lahirumaramba lahirumaramba merged commit 948a5b5 into dev Mar 4, 2022
@lahirumaramba lahirumaramba deleted the lm-update-go-115 branch March 4, 2022 22:41
lahirumaramba added a commit that referenced this pull request Apr 6, 2022
- Bumped version to 4.8.0
- Includes #412 #485 #492
lahirumaramba added a commit that referenced this pull request Apr 6, 2022
- Bumped version to 4.8.0
- Includes #412 #485 #492
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:stage Stage a release candidate release-note
2 participants