-
Notifications
You must be signed in to change notification settings - Fork 46k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[compiler][ez] Rename disableMemoizationForDebugging to just disableMemoization #30191
Open
mvitousek
wants to merge
9
commits into
gh/mvitousek/13/base
Choose a base branch
from
gh/mvitousek/13/head
base: gh/mvitousek/13/base
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+10
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…emoization Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This was referenced Jul 2, 2024
mvitousek
added a commit
that referenced
this pull request
Jul 2, 2024
…emoization Summary: We don't really need to make positive claims about what a particular mode is for in the name ghstack-source-id: a9b77181b694423317183483f76809ea0e07482e Pull Request resolved: #30191
kassens
approved these changes
Jul 2, 2024
…st disableMemoization" Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Jul 2, 2024
…emoization Summary: We don't really need to make positive claims about what a particular mode is for in the name ghstack-source-id: e1e161a227ea65faf1a5ed075d7459f128190679 Pull Request resolved: #30191
Comparing: 512b09b...541a905 Critical size changesIncludes critical production bundles, as well as any change greater than 2%:
Significant size changesIncludes any change greater than 0.2%: Expand to show
|
josephsavona
approved these changes
Jul 11, 2024
…st disableMemoization" Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
This was referenced Jul 18, 2024
mvitousek
added a commit
that referenced
this pull request
Jul 18, 2024
…emoization Summary: We don't really need to make positive claims about what a particular mode is for in the name ghstack-source-id: 99d46d079684fd2649fe08ae7e17fc3ea38b1eff Pull Request resolved: #30191
…st disableMemoization" Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Jul 18, 2024
…emoization Summary: We don't really need to make positive claims about what a particular mode is for in the name ghstack-source-id: 35170e05032e2fabaaf98256a8f0c6c6fa8006ac Pull Request resolved: #30191
…st disableMemoization" Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Jul 18, 2024
…emoization Summary: We don't really need to make positive claims about what a particular mode is for in the name ghstack-source-id: 00023f76b4e11eccbc0d3091e423a461682253d3 Pull Request resolved: #30191
…st disableMemoization" Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
mvitousek
added a commit
that referenced
this pull request
Jul 18, 2024
…emoization Summary: We don't really need to make positive claims about what a particular mode is for in the name ghstack-source-id: 8f995d22af10bdeb158c778016cbe80baf38a692 Pull Request resolved: #30191
…st disableMemoization" Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
…st disableMemoization" Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
…st disableMemoization" Summary: We don't really need to make positive claims about what a particular mode is for in the name [ghstack-poisoned]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary: We don't really need to make positive claims about what a particular mode is for in the name