Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[compiler][ez] Rename disableMemoizationForDebugging to just disableMemoization #30191

Open
wants to merge 9 commits into
base: gh/mvitousek/13/base
Choose a base branch
from

Conversation

…emoization

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
Copy link

vercel bot commented Jul 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-compiler-playground ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2024 10:59pm
…st disableMemoization"

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jul 2, 2024
…emoization

Summary: We don't really need to make positive claims about what a particular mode is for in the name

ghstack-source-id: e1e161a227ea65faf1a5ed075d7459f128190679
Pull Request resolved: #30191
@react-sizebot
Copy link

react-sizebot commented Jul 2, 2024

Comparing: 512b09b...541a905

Critical size changes

Includes critical production bundles, as well as any change greater than 2%:

Name +/- Base Current +/- gzip Base gzip Current gzip
oss-stable/react-dom/cjs/react-dom.production.js = 6.68 kB 6.68 kB = 1.83 kB 1.83 kB
oss-stable/react-dom/cjs/react-dom-client.production.js = 499.44 kB 499.44 kB = 89.59 kB 89.59 kB
oss-experimental/react-dom/cjs/react-dom.production.js = 6.69 kB 6.69 kB = 1.83 kB 1.83 kB
oss-experimental/react-dom/cjs/react-dom-client.production.js = 504.26 kB 504.26 kB = 90.30 kB 90.30 kB
facebook-www/ReactDOM-prod.classic.js = 599.20 kB 599.20 kB = 105.79 kB 105.79 kB
facebook-www/ReactDOM-prod.modern.js = 573.37 kB 573.37 kB = 101.68 kB 101.68 kB
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Significant size changes

Includes any change greater than 0.2%:

Expand to show
Name +/- Base Current +/- gzip Base gzip Current gzip
test_utils/ReactAllWarnings.js Deleted 64.07 kB 0.00 kB Deleted 15.86 kB 0.00 kB

Generated by 🚫 dangerJS against 541a905

…st disableMemoization"

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jul 18, 2024
…emoization

Summary: We don't really need to make positive claims about what a particular mode is for in the name

ghstack-source-id: 99d46d079684fd2649fe08ae7e17fc3ea38b1eff
Pull Request resolved: #30191
…st disableMemoization"

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jul 18, 2024
…emoization

Summary: We don't really need to make positive claims about what a particular mode is for in the name

ghstack-source-id: 35170e05032e2fabaaf98256a8f0c6c6fa8006ac
Pull Request resolved: #30191
…st disableMemoization"

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jul 18, 2024
…emoization

Summary: We don't really need to make positive claims about what a particular mode is for in the name

ghstack-source-id: 00023f76b4e11eccbc0d3091e423a461682253d3
Pull Request resolved: #30191
…st disableMemoization"

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
mvitousek added a commit that referenced this pull request Jul 18, 2024
…emoization

Summary: We don't really need to make positive claims about what a particular mode is for in the name

ghstack-source-id: 8f995d22af10bdeb158c778016cbe80baf38a692
Pull Request resolved: #30191
…st disableMemoization"

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
…st disableMemoization"

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
…st disableMemoization"

Summary: We don't really need to make positive claims about what a particular mode is for in the name

[ghstack-poisoned]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants