Use Ray object store for shuffle exchange #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
franklsf95
commented
Mar 6, 2023
| @@ -67,15 +73,15 @@ impl PyContext { | |||
| } | |||
|
|
|||
| pub fn plan(&self, sql: &str, py: Python) -> PyResult<PyExecutionGraph> { | |||
| debug!("Planning {}", sql); | |||
There was a problem hiding this comment.
This is a dumb question, but how do I make debug!() to print stuff? I tried export RUST_LOG=debug but still can't see any debug output.
There was a problem hiding this comment.
We need to add a dependency on a logger implementation (such as https://docs.rs/env_logger/latest/env_logger/) and initialize the logger somewhere
| @@ -82,6 +84,8 @@ impl QueryStage { | |||
| fn collect_child_stage_ids(plan: &dyn ExecutionPlan, ids: &mut Vec<usize>) { | |||
| if let Some(shuffle_reader) = plan.as_any().downcast_ref::<ShuffleReaderExec>() { | |||
| ids.push(shuffle_reader.stage_id); | |||
| } else if let Some(shuffle_reader) = plan.as_any().downcast_ref::<RayShuffleReaderExec>() { | |||
There was a problem hiding this comment.
Any way to do this in one statement?
andygrove
reviewed
Mar 7, 2023
raysql/context.py
Outdated
Comment on lines
35
to
36
| # TODO(@lsf): can there ever be more than 1 child future? | ||
| inputs = child_futures[0] if len(child_futures) > 0 else [] |
There was a problem hiding this comment.
Yes, there can be multiple inputs for joins, unions, and some other operators
improve error handling
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ResultSetpicklable