Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decoding Timestamp as Decimal128 #96

Merged
merged 3 commits into from
Jun 20, 2024

Conversation

progval
Copy link
Contributor

@progval progval commented Jun 19, 2024

This allows support for the full range of ORC timestamp, with full precision.

This allows support for the full range of ORC timestamp, with full precision.
@progval progval marked this pull request as draft June 20, 2024 07:17
@progval progval marked this pull request as ready for review June 20, 2024 07:22
@progval
Copy link
Contributor Author

progval commented Jun 20, 2024

I needed to add Some(UTC) => Box::new(iter), to avoid overflows in the main Some(writer_tz) => branch. Unfortunately, this means the Some(writer_tz) => branch does not have automated tests anymore (though tests did run when removing the first branch).

I don't think pyorc supports writing non-UTC timezones, so I don't see how to write a test file for that case. Should I leave it untested? Or just return an error on non-UTC writer timezone?

Copy link
Collaborator

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM🤩, thanks!

@WenyXu WenyXu merged commit f93314a into datafusion-contrib:main Jun 20, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants