Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for configuring time units through ArrowReaderBuilder::with_schema #93

Merged
merged 2 commits into from
Jun 16, 2024

Conversation

progval
Copy link
Contributor

@progval progval commented Jun 4, 2024

Mostly resolves #75, though users may want to decode timestamps as two i64 columns in order to preserve both precision and range. (Or could Arrow be extended to support i128 timestamps?)

@progval progval marked this pull request as ready for review June 5, 2024 12:17
@progval progval force-pushed the ts-precision branch 2 times, most recently from 29e3dcb to 4212522 Compare June 5, 2024 12:22
Copy link
Collaborator

@WenyXu WenyXu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@WenyXu WenyXu merged commit 95ebf43 into datafusion-contrib:main Jun 16, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants