Error instead of panic on timestamp overflow #91
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
progval
force-pushed
the
timestamp-overflow
branch
from
6c7c166
to
065c9f0
Compare
waynexia
approved these changes
May 24, 2024
There was a problem hiding this comment.
Looks like this file is not changed?
There was a problem hiding this comment.
I re-ran tests/basic/data/generate_orc_timestamps.py, which writes both files. It probably changed some metadata, I'll undo it.
I would have prefered either returning a null value or trying to encode as a non-nanosecond timestamp (sometimes possible if the ORC data does not use nanosecond-level precision), but this would require more significant changes to the code.
progval
force-pushed
the
timestamp-overflow
branch
from
065c9f0
to
09e2c4a
Compare
|
Great 👍 I'm going to merge this |
|
Thanks for this 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I would have prefered either returning a null value or trying to encode as a non-nanosecond timestamp (sometimes possible if the ORC data does not use nanosecond-level precision), but this would require more significant changes to the code.