Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#62 added filtering by rows and columns #87

Merged
merged 2 commits into from
Apr 22, 2024
Merged

#62 added filtering by rows and columns #87

merged 2 commits into from
Apr 22, 2024

Conversation

klangner
Copy link
Contributor

Added to the orc-exporter

  • filter by rows
  • filter by columns
  • skip unsupported columns (e.g binary for csv)
Jefffrey
Jefffrey reviewed Apr 21, 2024
View reviewed changes
Copy link
Collaborator

@Jefffrey Jefffrey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this, left some comments 👍
src/bin/orc-export.rs Outdated Show resolved Hide resolved
src/bin/orc-export.rs Outdated Show resolved Hide resolved
src/bin/orc-export.rs Show resolved Hide resolved
src/bin/orc-export.rs Outdated Show resolved Hide resolved
@klangner klangner requested a review from Jefffrey April 22, 2024 19:20
@Jefffrey Jefffrey merged commit cb5a1fc into datafusion-contrib:main Apr 22, 2024
9 checks passed
@Jefffrey
Copy link
Collaborator

Cheers 👍
@klangner
Copy link
Contributor Author

Thank you for your time too :-)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
2 participants
@klangner @Jefffrey