Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README and Dockerfile #124

Merged
merged 6 commits into from
Apr 28, 2024

Conversation

adamreeve
Copy link
Contributor

@adamreeve adamreeve commented Jan 11, 2024

This PR includes a few tidy ups and fixes to examples in the README:

  • Update versions of Arrow and DataFusion referenced in the README
  • Update the version of datafusion-java used
  • Update the Dockerfile so that jshell works again and update the section about using jshell in the README
  • Fix invalid references to ExecutionContexts that should be SessionContexts
  • Update the example code to include the full class definition and required import statements to make it easier to use

Some of this work is thanks to @pavlovic-ivan and was originally contributed in the G-Research fork

@adamreeve adamreeve changed the title Readme update Jan 11, 2024
Dockerfile Outdated
@@ -1,4 +1,4 @@
FROM openjdk:11-jdk-slim-bullseye
FROM openjdk:21-jdk-slim-bullseye
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe use alternative distro other than openjdk?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the issue with OpenJDK, and do you have a recommendation? I don't usually do a lot of Java development to be honest so I'm not very familiar with the alternatives 😅

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not about the jdk version but more of an issue with dockerfile and docker image

i'd personally use https://hub.docker.com/_/amazoncorretto

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if you look at https://hub.docker.com/_/openjdk it shows it's deprecated @adamreeve

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 makes sense thanks, I wasn't aware it was deprecated. I've changed the base image to be Amazon Corretto now.

@jimexist jimexist merged commit 58bccbd into datafusion-contrib:main Apr 28, 2024
4 checks passed
@adamreeve adamreeve deleted the readme_update branch April 28, 2024 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants