Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding golang example #16

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

KennethThompson
Copy link

Sorry- I am new to pull requests so some extra bits got swept in. Please consider adding the sql.go

Copy link
Member

@kou kou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Can I push fixes to this branch directly or do you want to fix by yourself?

Here are items we need to fix:

  • Remove .vscode/: It seems that it depends on your environment.
  • Revert needless change in examples/sql.py.
  • Add license header to examples/sql.go.
  • Add a step to our CI job to run examples/sql.go.
  • Add a configuration to build examples/sql.go into examples/meson.build.
  • Add a description about examples/sql.go into README.md.
@KennethThompson
Copy link
Author

I'll give it a shot. I was once useful, but now its hit or miss.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
3 participants