-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
upgrade to datafusion 8.0.0 #5
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jychen7
commented
Jun 26, 2022
jychen7
commented
Jun 26, 2022
jychen7
commented
Jun 26, 2022
@@ -293,3 +157,158 @@ impl ExecutionPlan for BigtableExec { | |||
} | |||
} | |||
|
|||
async fn execute_query( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same as original async fn execute
, separate because execute
in the trait is defined as sync
now
jychen7
commented
Jun 26, 2022
execute_query(self.clone()).map_err(|e| ArrowError::ExternalError(Box::new(e))) | ||
).try_flatten(); | ||
let schema = self.schema(); | ||
Ok(Box::pin(RecordBatchStreamAdapter::new(schema, stream))) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the key to delay async execute_query
to stream
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #4
Problem
there is a breaking change of datafusion v8
also original implementation "should not" call
bigtable.read_rows
during plan phaseexecute
. It should deferred to the return streamSolution
split original async method
execute
toexecute_query
and usefutures::stream::once
andRecordBatchStreamAdapter
to wrap it in plan phaseexecute
To reviewers
please review by commits. Datafusion 8 requires some change on ExecutionPlan, thus I split it to another file first