Skip to content
This repository has been archived by the owner on Sep 10, 2020. It is now read-only.

Show .ts files in js list #343

Merged
merged 1 commit into from
May 7, 2020
Merged

Conversation

Glennmen
Copy link
Contributor

@Glennmen Glennmen commented May 7, 2020

Currently cdnjs saves typescript files but they aren't listed in the cdnjs website. This PR will add them in the js list.

If needed it can be added as a separate list but I noticed that scss files are also listed in the css list.

@MattIPv4
Copy link
Member

MattIPv4 commented May 7, 2020

This website is being replaced by cdnjs/static-website which uses the whitelist the API provides (api.cdnjs.com/whitelist), which inludes TS.

@Glennmen
Copy link
Contributor Author

Glennmen commented May 7, 2020

I am aware of this but it hasn't been replaced yet and there is no public ETA or is this repo marked as archived.
So I assumed that it is stil open for improvements.

@MattIPv4
Copy link
Member

MattIPv4 commented May 7, 2020

Hm, yeah. Annoyingly I don't really have a timeline for the new new site, mostly just blocked by my lack of time to write API docs at this point.

I think this repo is still auto-deploying, so we can merge this so the old site shows ts files for now 👍

@MattIPv4 MattIPv4 self-requested a review May 7, 2020 19:42
Copy link
Member

@MattIPv4 MattIPv4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@MattIPv4 MattIPv4 merged commit 4b6e946 into cdnjs:master May 7, 2020
@Glennmen
Copy link
Contributor Author

Glennmen commented May 7, 2020

Thank you ❤️

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
2 participants