Replace flake8 with ruff #12605

bryevdv · 2022-11-13T18:40:11Z

Hi @bokeh/core I became aware of ruff as a possible alternative to flake8 implemented in Rust, and created a branch just to experiment. I quickly became convinced that ruff is a dramatically better alternative, and I would very strongly encourage us to switch entirely.

Ruff is ~150-200x faster than flake8 on my machine, scanning the whole repo takes ~0.2s instead of ~20s. This is an enormous quality of life improvement for local dev. It's fast enough that I added it as an actual commit hook, which is terrific.
Shaving tens of seconds off several CI jobs will be nice as well
Ruff replaces two packages flake8 and flake8-pyi with a single package, and also allows top-level configuration to be further consolidated in to pyproject.toml
Ruff supports many more checks that we could consider adding over time
Ruff has finer grained exclusions, we can now properly check all the __init__.py we were skipping entirely, previously
Ruff detected several problems and improvements that flake8 was not, including at least one legitimate bug (see comment inline)

It's also potentially possible that Ruff could replace isort at some point as well. isort is the other very slow codebase check, so that would be nice. But I think it's too early for that (esp since we have different configs in different subdirs)

fixes light_minimal theme is missing #12610

bryevdv · 2022-11-13T18:40:41Z

src/bokeh/themes/__init__.py

@@ -93,7 +93,7 @@
 built_in_themes = {
    CALIBER       : Theme(json=_caliber.json),
    DARK_MINIMAL  : Theme(json=_dark_minimal.json),
-    LIGHT_MINIMAL : Theme(json=_caliber.json),
+    LIGHT_MINIMAL : Theme(json=_light_minimal.json),


This was an actual bug, not sure how long it has been this way

bryevdv · 2022-11-13T18:47:38Z

examples/basic/data/color_mappers.py

    :refs: :ref:`ug_topics_images_colormapped`
    :keywords: color, tools, scatter, data_map

-'''
+''' # noqa: E501


Some day we will get automatic api-linking in example code and do away with :apis: alogether, but until then, this is much nicer to work with long docstring lines.

examples/models/buttons.py

codecov · 2022-11-13T18:58:15Z

Codecov Report

Merging #12605 (9c1d360) into branch-3.1 (4627189) will not change coverage.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           branch-3.1   #12605   +/-   ##
===========================================
  Coverage       92.15%   92.15%           
===========================================
  Files             312      312           
  Lines           19560    19560           
===========================================
  Hits            18026    18026           
  Misses           1534     1534

bryevdv · 2022-11-14T17:24:07Z

@bokeh/core unless there are comments/objections, I will plan to merge this Wednesday.

bryevdv · 2022-11-16T17:46:39Z

Absent any further input in the last two days, I will merge this now.

bryevdv · 2022-11-16T19:10:17Z

Just for FYI: brand new version of ruff caught some additional spurious # noqa after merge, I pushed a tiny commit to fix directly: 1f73a5a

bokeh/bokeh#12605

* apply fixes * stricter, more fixes * more fixes, check __init__.py better * remove flake8 * add U amd W checks * combine imports

* Neutral POV for install instructions (#12603) * Neutral POV for install instructions * Update README.md Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> * Fix export with fractional CSS lengths (#12613) * Fix layout propagation in nested mixed layouts (#12612) * Replace flake8 with ruff (#12605) * apply fixes * stricter, more fixes * more fixes, check __init__.py better * remove flake8 * add U amd W checks * combine imports * remove spurious # noqa * Remove LGTM (#12620) LGTM service will shut down in a few weeks. https://github.blog/2022-08-15-the-next-step-for-lgtm-com-github-code-scanning/#end-of-november-new-commits-and-pull-requests-are-no-longer-analyzed * Added metadata to glyphs.py, multi_legend.py, multi_scale.py (#12547) * Added metadata to glyphs.py, multi_legend.py, multi_scale.py * Removed trailing whitespaces. * Pared down apis to the most interesting and put it in a single line. * Added the apis in a single line and updated the keywords. * Bv/deprecated apis in tests (#12622) * pydot -> pygraphviz * remove publish_display_data source param * Exlude tmp files from coverage (#12629) * exlude tmp files from coverage * silence linter * Update CodeQL action (#12630) * Update CodeQL action * kick the tires * Fix application of UI element styles in Firefox (#12634) * Add CodeQL config (#12636) * codeql config in proper job * Updates to Docker image building and testing (#12351) * Updates to docker image building * Support all non-firefox tests in docker container * Try ECR upload * Update ECR region and repository * Chromedriver version does not have to match chrome version * Try ECR upload * Try adding custom registry alias * try default registry alias * Try default alias take 2 * specify public registry login * fix registry type config * Try dockerhub * fix typo * Try multiple tags * Option to push or save image * Github action to run tests in docker container * Temporarily force BokehJS-CI to run * Try to get docker testing to run in CI * Run docker in CI using wheel * Use entrypoint script to install from wheel * Final tweaks * Switch to docker testing using image named branch-3.1 * Add test running chromium in Docker without required envvar * Move test-in-docker to separate workflow * Better docker CI names Co-authored-by: Bryan Van de Ven <bryan@bokeh.org> * Disable docker from wheel integration tests (#12639) * Added find_stack_level to util.warnings (#12650) * Added find_stack_level to util.deprecation * Moving deprecation -> warnings * Change to use internal warn * Fix import * Fix lint * Fix failing test * Resolve issues with code quality checks (#12654) * Use type[T] instead of Type[T] where permitted * Pin ruff to last working version (0.0.144) * Compute layout for initially undisplayed components (#12653) * Fix broken bokeh-tree links (#12644) * fix broken bokeh-tree links * fix broken metadata ref * more versioned links * lint * CodeQL: remove import linter hack (#12645) * remove API import lint hack in properties.py * remove API import lint hack in plotting/__init__.py * remove API import lint hack in sampledata/__init__.py * remove API import lint hack in document/__init__.py * remove API import lint hack in embed/util.py * remove API import lint hack in top level __init__.py * remove API import lint hack in model/util.py * clean up doc event imports * clean up defaults tests imports * remove non-functional spec.py * review changes * Add default styles to FILE template (#12656) * Add default styles to FILE template * Don't ignore template files * Skip stocks and surface3d examples * Adapt Bokeh logo for dark theme and add docs badge in README.md (#12659) Co-authored-by: Moritz Schreiber <68053396+mosc9575@users.noreply.github.com> Co-authored-by: Mateusz Paprocki <mattpap@gmail.com> Co-authored-by: Yash Pratapwar <65851650+Yash-Pratapwar@users.noreply.github.com> Co-authored-by: Ian Thomas <ianthomas23@gmail.com> Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com> Co-authored-by: Pavithra Eswaramoorthy <pavithraes@outlook.com>

bryevdv added 6 commits November 13, 2022 08:40

apply fixes

de0092c

stricter, more fixes

976237f

more fixes, check __init__.py better

2c35e6d

remove flake8

2da1fa6

add U amd W checks

aeed80b

combine imports

9c1d360

bryevdv added the status: ready label Nov 13, 2022

bryevdv commented Nov 13, 2022

View reviewed changes

mattpap reviewed Nov 13, 2022

View reviewed changes

examples/models/buttons.py Show resolved Hide resolved

mattpap added type: task tag: codebase Improvements to code quality without affecting any functionality. labels Nov 14, 2022

mattpap added this to the 3.1 milestone Nov 14, 2022

bryevdv mentioned this pull request Nov 14, 2022

light_minimal theme is missing #12610

Closed

bryevdv merged commit c9c0adf into branch-3.1 Nov 16, 2022

bryevdv deleted the bv/ruff branch November 16, 2022 17:46

bryevdv added reso: completed status: accepted and removed status: ready labels Nov 16, 2022

This was referenced Nov 24, 2022

Migrate to hatch nebari-dev/nebari#1545

Merged

Add support for use pyproject.toml django-wiki/django-wiki#1227

Merged

minghongx added a commit to minghongx/deeprl that referenced this pull request Dec 4, 2022

Replace flake8 with ruff

4f4d44a

bokeh/bokeh#12605

bryevdv added a commit that referenced this pull request Dec 6, 2022

Replace flake8 with ruff (#12605)

ee5c0f2

* apply fixes * stricter, more fixes * more fixes, check __init__.py better * remove flake8 * add U amd W checks * combine imports

bryevdv mentioned this pull request Dec 6, 2022

Backports for 3.0.3 #12662

Merged

bryevdv removed this from the 3.1 milestone Dec 7, 2022

bryevdv added this to the 3.0.3 milestone Dec 7, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Replace flake8 with ruff #12605

Replace flake8 with ruff #12605

bryevdv commented Nov 13, 2022 •

edited

Loading

bryevdv Nov 13, 2022

bryevdv Nov 13, 2022

codecov bot commented Nov 13, 2022 •

edited

Loading

bryevdv commented Nov 14, 2022

bryevdv commented Nov 16, 2022

bryevdv commented Nov 16, 2022 •

edited

Loading

Replace flake8 with ruff #12605

Replace flake8 with ruff #12605

Conversation

bryevdv commented Nov 13, 2022 • edited Loading

bryevdv Nov 13, 2022

Choose a reason for hiding this comment

bryevdv Nov 13, 2022

Choose a reason for hiding this comment

codecov bot commented Nov 13, 2022 • edited Loading

Codecov Report

bryevdv commented Nov 14, 2022

bryevdv commented Nov 16, 2022

bryevdv commented Nov 16, 2022 • edited Loading

bryevdv commented Nov 13, 2022 •

edited

Loading

codecov bot commented Nov 13, 2022 •

edited

Loading

bryevdv commented Nov 16, 2022 •

edited

Loading