Android update NDK to latest version ndk26b #1415

crazyhappygame · 2023-11-01T13:42:44Z

Which branch your pull-request should merge into?

dev: Current 2.x BugFixs or Features

Describe your changes

Android update NDK to latest version ndk26b

Issue ticket number and link

Checklist before requesting a review

I have performed a self-review of my code.
If it is a core feature, I have added thorough tests.
I have checked readme and add important infos to this PR (if it needed).
I have added/adapted some tests too.

fix find_program call

* Ensure Live2D extension is enabled for Live2D test * Update Live2D to work with Axmol 2.x * [skip ci] Remove commented out shader code

* Allow optional setting target link scope for extensions when linking with Axmol. * Fix Live2D linking with Axmol on Android Add Android Tegra shader processing and usage

- Force cast corss config & build paramer to array to avoid combine with builtin parameters incorrect - Use evaluated build target to run and deploy

crazyhappygame · 2023-11-01T19:58:06Z

@halx99 can we merge this PR?

halx99 · 2023-11-02T02:09:47Z

This PR will break android device compatibility, so I add to next milestone.

crazyhappygame · 2023-11-02T06:56:29Z

What do you mean by "break android device compatibility"?
https://github.com/android/ndk/wiki/Changelog-r26

KitKat (APIs 19 and 20) is no longer supported. The minimum OS supported by the NDK is Lollipop (API level 21). See Issue 1751 for details.

halx99 · 2023-11-02T07:19:41Z

What do you mean by "break android device compatibility"? https://github.com/android/ndk/wiki/Changelog-r26

KitKat (APIs 19 and 20) is no longer supported. The minimum OS supported by the NDK is Lollipop (API level 21). See Issue 1751 for details.

means build apk with ndk-r25+ can't runs on android 4.2 devices

rh101 · 2023-11-02T12:07:52Z

Wouldn't it be better to keep the NDK at the lowest possible version to not limit any devices? There is support in the build scripts to change the version used by passing it at the command line.

halx99 · 2023-11-02T14:16:37Z

Wouldn't it be best to keep the NDK at the lowest possible version to not limit any devices? There is support in the build scripts to change the version used by passing it at the command line.

for example: axmol build -p android -a arm64 -cc ndk-r25c

crazyhappygame · 2023-11-02T15:23:47Z

r26b is the latest supported version - LTS Version.
All other NDK versions are not officially supported any more:
Please check https://github.com/android/ndk/wiki/Unsupported-Downloads
Using unsuported NDK is gray zone (will it work with latest android version? will it work with other android libraries?)

I think that official axmol configuration by default should be build based on officially supported libraries. If someone need to support older versions 4.2, 4.1 3.0 android then probably "-cc ndk-r25c" or older can be used

halx99 · 2023-11-03T03:18:28Z

sorry, i don't agree, axmol was tested with ndk-r23c, and works well, new devices related to sdk platform, usually not limit ndk versions. I also have check the latest unity 2023, it use ndk-r23b. we should keep it except there are critical issues of it(crashing, generating incorrect code, ...) 获取Outlook for Android<https://aka.ms/AAb9ysg>

…

________________________________ From: CHP ***@***.***> Sent: Thursday, November 2, 2023 11:23:58 PM To: axmolengine/axmol ***@***.***> Cc: Deal ***@***.***>; Mention ***@***.***> Subject: Re: [axmolengine/axmol] Android update NDK to latest version ndk26b (PR #1415) r26b is the latest supported version - LTS Version. All other NDK versions are not officially supported any more: Please check https://github.com/android/ndk/wiki/Unsupported-Downloads Using unsuported NDK is gray zone (will it work with latest android version? will it work with other android libraries?) I think that official axmol configuration by default should be build based on officially supported libraries. If someone need to support older versions 4.2, 4.1 3.0 android then probably "-cc ndk-r25c" or older can be used ― Reply to this email directly, view it on GitHub<#1415 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABVHOJZWM6DA7CWVLJP3HATYCO3I5AVCNFSM6AAAAAA6ZJ37DGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQHE2TAMRRGQ>. You are receiving this because you were mentioned.Message ID: ***@***.***>

halx99 · 2023-11-03T03:20:12Z

sorry, i don't agree, axmol was tested with ndk-r23c, and works well, new devices related to sdk platform, usually not limit ndk versions. I also have check the latest unity 2023, it use ndk-r23b. we should keep it except there are critical issues of it(crashing, generating incorrect code, ...) 获取Outlook for Androidhttps://aka.ms/AAb9ysg
…
________________________________ From: CHP @.> Sent: Thursday, November 2, 2023 11:23:58 PM To: axmolengine/axmol @.> Cc: Deal @.>; Mention @.> Subject: Re: [axmolengine/axmol] Android update NDK to latest version ndk26b (PR #1415) r26b is the latest supported version - LTS Version. All other NDK versions are not officially supported any more: Please check https://github.com/android/ndk/wiki/Unsupported-Downloads Using unsuported NDK is gray zone (will it work with latest android version? will it work with other android libraries?) I think that official axmol configuration by default should be build based on officially supported libraries. If someone need to support older versions 4.2, 4.1 3.0 android then probably "-cc ndk-r25c" or older can be used ― Reply to this email directly, view it on GitHub<#1415 (comment)>, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABVHOJZWM6DA7CWVLJP3HATYCO3I5AVCNFSM6AAAAAA6ZJ37DGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOJQHE2TAMRRGQ. You are receiving this because you were mentioned.Message ID: @.***>

maybe after 3-5 years, we can update ndk

halx99 · 2023-11-03T03:22:17Z

core/platform/android/libaxmol/axutils.gradle

@@ -97,7 +97,7 @@ class axutils {
 //    }

    @SuppressWarnings('unused')
-    static String[] findNativeBuildTools(project, cmakeVer = "3.22.1+", ndkVer = "23.2.8568313") {
+    static String[] findNativeBuildTools(project, cmakeVer = "3.22.1+", ndkVer = "26.1.10909125") {


should also change api leve in all gradle projects

Thank you. API changed to 21.
I did it once 0585fe5 but it was reverted

Thank you. API changed to 21. I did it once 0585fe5 but it was reverted

yes, because when i build apk, can't install to android 4.2 emulator for testing GLESv2 compatibility.

crazyhappygame · 2023-11-03T08:11:50Z

NDK maintainers recommend to use always latest NDK.
https://groups.google.com/g/android-ndk/c/OIek2jtx2I8/m/WjAT5eXcCQAJ

Google Play services discontinuing updates for KitKat (API levels 19 & 20) starting August 2023
https://android-developers.googleblog.com/2023/07/google-play-services-discontinuing-updates-for-kitkat.html

I understand that for some developers support ~10 years old devices and android 4.4 KitKat (~0.4%) can be required but I think that for most of us supporting devices that are officially supported by Google is the way to go.

halx99 and others added 30 commits September 1, 2023 01:07

Merge branch '1.x' into dev

2a6e84a

Fix cmake setup for linux

7514e06

build.ps1: translate array options

2969a5b

Merge branch '1.x' into dev

89955d9

Auto get release list for doc build

279ea74

Merge branch '1.x' into dev

8f88145

Auto deploy wasm demo to gh pages

bdbbc55

Merge branch '1.x' into dev

c8bd342

Update gendocs.ps1

f1153d0

Auto deploy wasm demo to gh pages

a9e5d51

Update docs

94fe44a

Sync docs [skip ci]

e27d271

Update site build

6a08ac7

Sync #1316

7929681

Update AXBuildHelpers.cmake (#1316)

a7133b5

fix find_program call

Merge branch '1.x' into dev

6d82d3a

consle-next: Looking both powershell 7.x and 5.x

5e3cba7

Merge branch '1.x' into dev

c8bfa8c

Add webgl aka wasm build support (#1315)

062b510

Update ax_audioengine.ini

22974b8

Committing genbindings changes

5b26455

Merge 1.x WASM support into 'dev'

c469e8a

Merge branch '1.x' into dev

41714a0

Fix gendocs.ps1

2631c84

Merge branch '1.x' into dev

d1c6319

Update reademe files

22e9410

Fix ios ci

5ada438

Particle3D: add wasm support for load materials

1988574

Fix ios ci

dc39bee

Fix ios ci

3da53f1

rh101 and others added 7 commits October 25, 2023 19:25

Update Live2D to work with Axmol 2.x (#1405)

05e3ddd

* Ensure Live2D extension is enabled for Live2D test * Update Live2D to work with Axmol 2.x * [skip ci] Remove commented out shader code

Live2d Android build fix (#1407)

b362b4c

* Allow optional setting target link scope for extensions when linking with Axmol. * Fix Live2D linking with Axmol on Android Add Android Tegra shader processing and usage

Improve axmol console

b56a60a

- Force cast corss config & build paramer to array to avoid combine with builtin parameters incorrect - Use evaluated build target to run and deploy

Make AxmolEditBox invisible by default. (#1414)

1a4d05b

Update build1k.ps1

d7d6bd6

Update axutils.gradle to use by default

2b8e55a

Update genbindings.py

aedf518

halx99 added this to the next milestone Nov 1, 2023

halx99 added the breaks compatibility label Nov 1, 2023

halx99 self-requested a review November 3, 2023 02:45

This comment was marked as duplicate.

Sign in to view

halx99 reviewed Nov 3, 2023

View reviewed changes

PROP_MIN_SDK_VERSION=21

0d1f0b1

crazyhappygame requested a review from halx99 November 3, 2023 07:54

halx99 modified the milestones: next, 2.2.0 Nov 3, 2023

halx99 modified the milestones: 2.2.0, next Nov 14, 2023

halx99 closed this Dec 7, 2023

halx99 force-pushed the dev branch from 657d69b to 292c45c Compare December 7, 2023 12:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Android update NDK to latest version ndk26b #1415

Android update NDK to latest version ndk26b #1415

crazyhappygame commented Nov 1, 2023

crazyhappygame commented Nov 1, 2023

halx99 commented Nov 2, 2023

crazyhappygame commented Nov 2, 2023

halx99 commented Nov 2, 2023

rh101 commented Nov 2, 2023 •

edited

Loading

halx99 commented Nov 2, 2023

crazyhappygame commented Nov 2, 2023

halx99 commented Nov 3, 2023 via email

halx99 commented Nov 3, 2023

This comment was marked as duplicate.

halx99 Nov 3, 2023

crazyhappygame Nov 3, 2023

halx99 Nov 3, 2023

crazyhappygame commented Nov 3, 2023

Android update NDK to latest version ndk26b #1415

Android update NDK to latest version ndk26b #1415

Conversation

crazyhappygame commented Nov 1, 2023

Describe your changes

Issue ticket number and link

Checklist before requesting a review

crazyhappygame commented Nov 1, 2023

halx99 commented Nov 2, 2023

crazyhappygame commented Nov 2, 2023

halx99 commented Nov 2, 2023

rh101 commented Nov 2, 2023 • edited Loading

halx99 commented Nov 2, 2023

crazyhappygame commented Nov 2, 2023

halx99 commented Nov 3, 2023 via email

halx99 commented Nov 3, 2023

This comment was marked as duplicate.

halx99 Nov 3, 2023

Choose a reason for hiding this comment

crazyhappygame Nov 3, 2023

Choose a reason for hiding this comment

halx99 Nov 3, 2023

Choose a reason for hiding this comment

crazyhappygame commented Nov 3, 2023

rh101 commented Nov 2, 2023 •

edited

Loading