fix: plaintextLength must be enforced #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the user has expressed a plaintext length, this value MUST not be exceed.
mattsb42-aws
requested changes
Sep 18, 2019
| * The Maximum.BYTES_PER_CACHED_KEY_LIMIT is set to be within Number.MAX_SAFE_INTEGER | ||
| * See serialize/identifiers.ts enum Maximum for more details. | ||
| */ | ||
| needs(!plaintextLength || (plaintextLength >= 0 && Maximum.BYTES_PER_CACHED_KEY_LIMIT >= plaintextLength), 'plaintextLength out of bounds.') |
There was a problem hiding this comment.
Per offline discussion, Maximum.BYTES_PER_CACHED_KEY_LIMIT is the incorrect limit to apply here.
It should be Maximum.FRAME_COUNT * Maximum.FRAME_SIZE.
Because of the JS number limitations, this ends up needing to have the same numerical value, but we need to define it as a separate limit identifier.
mattsb42-aws
approved these changes
Sep 19, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the user has expressed a plaintext length,
this value MUST not be exceed.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Check any applicable: